Commit d737978
authored
fix: fix release-please PR title pattern and permissions (prometheus#1978)
## Summary
- Add `group-pull-request-title-pattern` with `${version}` so
release-please can match the merged PR and create the GitHub release.
The default group title is `chore: release main` which lacks the
version, preventing release creation on merge.
- Add `issues: write` permission (incorporates prometheus#1975)
- Remove `separate-pull-requests: false` (already the default)
- Remove redundant `extra-files` (maven type auto-discovers pom.xml)
Supersedes prometheus#1975
## Test plan
- [ ] CI passes
- [ ] After merge, release-please creates PR with title like
`chore(main): release 1.5.1`
- [ ] Merging that PR creates v1.5.1 tag and GitHub release
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>1 parent 89052fc commit d737978
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,11 +1,10 @@ | |||
| 1 | 1 | { | |
| 2 | 2 | "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", | |
| 3 | - "separate-pull-requests": false, | ||
| 3 | + "group-pull-request-title-pattern": "chore${scope}: release${component} ${version}", | ||
| 4 | 4 | "pull-request-footer": "> [!IMPORTANT]\n> Close and reopen this PR to trigger CI checks.", | |
| 5 | 5 | "packages": { | |
| 6 | 6 | ".": { | |
| 7 | - "release-type": "maven", | ||
| 8 | - "extra-files": ["integration-tests/it-spring-boot-smoke-test/pom.xml"] | ||
| 7 | + "release-type": "maven" | ||
| 9 | 8 | } | |
| 10 | 9 | } | |
| 11 | 10 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,6 +8,7 @@ on: | |||
| 8 | 8 | ||
| 9 | 9 | permissions: | |
| 10 | 10 | contents: write | |
| 11 | + issues: write | ||
| 11 | 12 | pull-requests: write | |
| 12 | 13 | ||
| 13 | 14 | jobs: | |
0 commit comments