Fixing MapScript unit tests for Python2 - #5569
Merged
Schpidi merged 48 commits intoMar 23, 2018
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… as marked as "severely broken"
This reverts commit d8a34e1.
Copy link
Copy Markdown
Member
|
Impressive, I'm just going to merge this to unblock further good work. Thanks a lot! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help check the usability of the Python3 MapScript bindings (see #5561, #5290) it will be useful to run the MapScript test suite to see which tests fail.
The Python2 unit tests have not been maintained for a number of years. This pull request aims to fix the tests in Python2 before running on Python3.
Some tests can be fixed by simply updating the API, such as adding A values to RGBA related-tests. Other failing tests are more complicated - comments have been added to individual commits.
Several failing tests relate to creating new image objects - marked with comments in the code noting "imageObj() is severely broken and should not be used". It may be time to clean up this code and remove the section of code marked #ifdef FORCE_BROKEN_GD_CODE
Several errors also relate to testing the getFeature/getResultsShape methods. These no longer exist, see:
These tests have been commented out for the moment, and may be deleted if no longer relevant.