Repository navigation
Commit cdcc9d8
committed
Suggestions from reviewers
- makes axes3d.Quaternion a private _Quaternion class
- shortens as_cardan_angles()
- adds two extra tests to test_axes3d::test_quaternion(): from_cardan_angles() should return a unit quaternion, and as_cardan_angles() should be insensitive to quaternion magnitude
- updates "mplot3d View Angles" documentation (the mouse can control both azimuth, elevation, and roll; and matlab does have a roll angle nowadays)
- put in a reference to quaternion multiplication using scalar and vector parts (wikipedia)
- rename class method that constructs a quaternion from two vectors to `rotate_from_to()`
- clarify docstring: "The quaternion for the shortest rotation from vector r1 to vector r2"
- issue warning when vectors are anti-parallel: "shortest rotation is ambiguous"
- construct a perpendicular vector for generic r2 == -r1
- add test case for anti-parallel vectors
- add test for the warning
- add reference to Ken Shoemake's arcball, in axes3d.py
- point out that angles are in radians, not degrees, in quaternion class docstrings
- in test_axes3d, add an import for axes3d._Quaternion, to avoid repetition
- add Quaternion conjugate(), and tests for it
- add Quaternion norm, and tests
- add Quaternion normalize(), and tests
- add Quaternion reciprocal(), and tests
- add Quaternion division, and tests
- add Quaternion rotate(vector), and a test1 parent ad26517 commit cdcc9d8
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -12,17 +12,16 @@ The position of the viewport "camera" in a 3D plot is defined by three angles: | |||
| 12 | 12 | points towards the center of the plot box volume. The angle direction is a | |
| 13 | 13 | common convention, and is shared with | |
| 14 | 14 | `PyVista <https://docs.pyvista.org/api/core/camera.html>`_ and | |
| 15 | - `MATLAB <https://www.mathworks.com/help/matlab/ref/view.html>`_ | ||
| 16 | - (though MATLAB lacks a roll angle). Note that a positive roll angle rotates the | ||
| 15 | + `MATLAB <https://www.mathworks.com/help/matlab/ref/view.html>`_. Note that a positive roll angle rotates the | ||
| 17 | 16 | viewing plane clockwise, so the 3d axes will appear to rotate | |
| 18 | 17 | counter-clockwise. | |
| 19 | 18 | ||
| 20 | 19 | .. image:: /_static/mplot3d_view_angles.png | |
| 21 | 20 | :align: center | |
| 22 | 21 | :scale: 50 | |
| 23 | 22 | ||
| 24 | - Rotating the plot using the mouse will control only the azimuth and elevation, | ||
| 25 | - but all three angles can be set programmatically:: | ||
| 23 | + Rotating the plot using the mouse will control azimuth, elevation, | ||
| 24 | + as well as roll, and all three angles can be set programmatically:: | ||
| 26 | 25 | ||
| 27 | 26 | import matplotlib.pyplot as plt | |
| 28 | 27 | ax = plt.figure().add_subplot(projection='3d') | |
0 commit comments