MNT: Warn if fixed aspect overwrites explicitly set data limits (#28683) · matplotlib/matplotlib@e8e12df · GitHub

matplotlib / matplotlib Public

• Notifications You must be signed in to change notification settings
• Fork 8.5k
• Star 23.3k

• Code
• Issues 1.1k
• Pull requests 432
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit e8e12df

Browse filesBrowse the repository at this point in the historyBrowse files

timhoffm

authored

MNT: Warn if fixed aspect overwrites explicitly set data limits (#28683)

Closes #28673.

1 parent ba05b44 commit e8e12df
Copy full SHA for e8e12df

1 file changed

+8-1Lines changed: 8 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/matplotlib/axes
  • _base.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/matplotlib/axes/_base.py‎

Copy file name to clipboardExpand all lines: lib/matplotlib/axes/_base.py

+8-1Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1713,7 +1713,8 @@ def set_adjustable(self, adjustable, share=False):
1713	1713	----------
1714	1714	adjustable : {'box', 'datalim'}
1715	1715	If 'box', change the physical dimensions of the Axes.
1716		- If 'datalim', change the ``x`` or ``y`` data limits.
	1716	+ If 'datalim', change the ``x`` or ``y`` data limits. This
	1717	+ may ignore explicitly defined axis limits.
1717	1718
1718	1719	share : bool, default: False
1719	1720	If ``True``, apply the settings to all shared Axes.
@@ -2030,11 +2031,17 @@ def apply_aspect(self, position=None):
2030	2031	yc = 0.5 * (ymin + ymax)
2031	2032	y0 = yc - Ysize / 2.0
2032	2033	y1 = yc + Ysize / 2.0
	2034	+ if not self.get_autoscaley_on():
	2035	+ _log.warning("Ignoring fixed y limits to fulfill fixed data aspect "
	2036	+ "with adjustable data limits.")
2033	2037	self.set_ybound(y_trf.inverted().transform([y0, y1]))
2034	2038	else:
2035	2039	xc = 0.5 * (xmin + xmax)
2036	2040	x0 = xc - Xsize / 2.0
2037	2041	x1 = xc + Xsize / 2.0
	2042	+ if not self.get_autoscalex_on():
	2043	+ _log.warning("Ignoring fixed x limits to fulfill fixed data aspect "
	2044	+ "with adjustable data limits.")
2038	2045	self.set_xbound(x_trf.inverted().transform([x0, x1]))
2039	2046
2040	2047	def axis(self, arg=None, /, *, emit=True, **kwargs):

0 commit comments

Comments

0 (0)