FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

MacOS backend modifier keys · Issue #1259 · matplotlib/matplotlib · GitHub

Repository navigation

MacOS backend modifier keys #1259

Closed
Closed

Description

The MacOS backend does not currently have modifier key support such as that available in TkAgg, GtkAgg, WxAgg, QT4Agg etc.

A simple test: Create a figure and try hitting ctrl+w

Note: Follows on from #851.

Activity

  1. dmcdougall commented on Sep 16, 2012

    Member

    I've been looking into this. The problem is the FigureCanvasMac class does not implement functions such as key_press_event, like the GTK backend does. My initial assessment is that this, although would be nice to have, will take a little time. It probably shouldn't stop the release candidate, but it should make it into a bugfix release, perhaps.

  2. pelson commented on Sep 17, 2012

    MemberAuthor

    It probably shouldn't stop the release candidate, but it should make it into a bugfix release, perhaps.

    There is no urgency on this IMHO. It is a thing that we would love to have done, but ultimately, will only get done if somebody really needs it (and is motivated to do it!). Personally, I wouldn't be concerned if this didn't get in until 1.3.

  3. mdehoon commented on Dec 12, 2012

    Contributor

    key_press_event for FigureCanvasMac is implemented in in the C code in _macosx.m in the keyDown method. Probably it's not difficult to add modifiers to it. Any volunteers?

  4. dmcdougall commented on Dec 12, 2012

    Member

    I started a local branch for this and never got round to finishing it. I'm happy to volunteer to do it, but I'd like to get some of my current pull requests completed before creating more unfinished pieces of work.

  5. dmcdougall commented on Dec 14, 2012

    Member

    (Please don't let that prevent anybody else from writing a patch. I can't find my branch anyway!)

  6. cimarronm commented on Mar 22, 2013

    Contributor

    Added a patch for this in #1841

  7. added a commit that references this issue on Mar 27, 2013
  8. dmcdougall commented on Mar 27, 2013

    Member

    #1841 merged; closing.

  9. pelson commented on Mar 27, 2013

    MemberAuthor

    Wooho thanks @cimarronm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL