FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Deprecate bbox and xy parameters to restore_region? · Issue #19095 · matplotlib/matplotlib · GitHub

Repository navigation

Deprecate bbox and xy parameters to restore_region? #19095

Open

Description

Describe the issue

Summary

RendererAgg.restore_region takes two optional kwargs, bbox and xy, which specify respectively a subregion and and offset for the restoring. These were introduced in b1c784d for manual animations where subregions of specific patterns would be blitted with certain offsets. This was demonstrated in a single example, which was removed in e547d6f, and never used anywhere else.

I would suggest deprecating and then getting rid of the feature: there doesn't seem to be much demand for it (no other use anywhere in the library or the examples); the kind of animation it allows is extremely specific, and likely it should be possible to build something similarly efficient using FigureImage (i.e., drawing a non-resampled array at a given position should really just involve setting the correspoding pixels in the bitmap) anyways.

Also, that means one less thing to implement in mplcairo for feature parity :)

Is there anyone opposed to such a removal?

Activity

  1. github-actions commented on Sep 18, 2023

    This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

  2. added
    keepItems to be ignored by the “Stale” Github Action
    and removed
    status: inactiveMarked by the “Stale” Github Action
    on Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    API: changesChanges to the public API, typically requiring deprecation.Maintenancebackend: aggkeepItems to be ignored by the “Stale” Github Actiontopic: animation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL