Activity

1. franzhaas

   added

   Maintenance

   on Nov 28, 2021
2. epeisach commented on Nov 29, 2021

   

   epeisach

   on Nov 29, 2021

   More actions

   I second this. setuptools-scm being installed on your system will affect other packages being built. The check that .git directory exists to decide on the pull in as an install requirement is wrong.

   Either setup.py needs to be changed - our when building packages in your CI - you must remove the .git directory.
3. tacaswell commented on Nov 30, 2021

   

   tacaswell

   on Nov 30, 2021

   Member

   More actions

   I am sold on the wheels not depending on setuptools-scm as a matter of principle, but if it being installed or not is breaking other packages for you @epeisach my knee-jerk reaction is that there are bugs in the other packages!
4. dopplershift commented on Nov 30, 2021

   

   dopplershift

   on Nov 30, 2021

   Contributor

   More actions

   setuptools_scm should only ever be a dependency of building the wheels, not runtime. @tacaswell I think this is a little suspect:

   matplotlib/setup.py

   Lines 315 to 328 in d536acf

   	install_requires=[
   	"cycler>=0.10",
   	"fonttools>=4.22.0",
   	"kiwisolver>=1.0.1",
   	"numpy>=1.17",
   	"packaging>=20.0",
   	"pillow>=6.2.0",
   	"pyparsing>=2.2.1,<3.0.0",
   	"python-dateutil>=2.7",
   	] + (
   	# Installing from a git checkout.
   	["setuptools_scm>=4"] if Path(__file__).with_name(".git").exists()
   	else []
   	),

   Do you remember why that install_requires portion was added?
5. tacaswell commented on Nov 30, 2021

   

   tacaswell

   on Nov 30, 2021

   Member

   More actions

   Because we have

   matplotlib/lib/matplotlib/__init__.py

   Lines 167 to 174 in d536acf

   	if (root / ".git").exists() and not (root / ".git/shallow").exists():
   	import setuptools_scm
   	return setuptools_scm.get_version(
   	root=root,
   	version_scheme="release-branch-semver",
   	local_scheme="node-and-date",
   	fallback_version=_version.version,
   	)

   in __init__.py to make the version auto-track in source installs (like we used to have with versioneer).
6. dopplershift commented on Nov 30, 2021

   

   dopplershift

   on Nov 30, 2021

   Contributor

   More actions

   In MetPy I chose to go with:

       try:
           from setuptools_scm import get_version
           return get_version(root='../..', relative_to=__file__,
                              version_scheme='post-release')
       except (ImportError, LookupError):
           try:
               from importlib.metadata import PackageNotFoundError, version
           except ImportError:  # Can remove when we require Python > 3.7
               from importlib_metadata import PackageNotFoundError, version
   
           try:
               return version(__package__)
           except PackageNotFoundError:
               return 'Unknown'

   and avoid polluting install_requires. I've also moved as much as possible to put metadata in setup.cfg, so I don't even have the option for this IMO anti-pattern of running code to determine install_requires.
7. QuLogic

   added 2 commits that reference this issue on Nov 30, 2021

   Drop setuptools-scm requirement in wheels

   This issue will close once commit efc3b69 is merged into the 'main' branch.

   efc3b69

   Drop setuptools-scm requirement in wheels

   This issue will close once commit 71ad05e is merged into the 'main' branch.

   71ad05e
8. QuLogic commented on Nov 30, 2021

   

   QuLogic

   on Nov 30, 2021

   Member

   More actions

   I suggest we do that for 3.6.0, and do the minimal patching in the above PR for 3.5.1.

   Reacted by Thomas A Caswell
9. tacaswell

   closed this as completedin #21820on Dec 1, 2021
10. QuLogic

    added this to the v3.5.1 milestone on Dec 1, 2021
11. pcorpet commented on Oct 9, 2023

    

    pcorpet

    on Oct 9, 2023

    More actions

    I still have setuptools-scm as a dep of matplotlib 3.8.0 in my lock file. Can you help me debug please? I see that it's in the requires_dist on PyPi: https://pypi.org/pypi/matplotlib/3.8.0/json. Aren't you pushing the lib to PyPi as a wheel?
12. ksunden commented on Oct 9, 2023

    

    ksunden

    on Oct 9, 2023

    Member

    More actions

    @pcorpet see #26932

    TLDR is that setuptools changed their sdist metadata generation, so while the wheels don't report that dependency the sdist (and thus pypi) report it. Will be fixed for 3.8.1

    Reacted by Pascal Corpet
13. QuLogic

    changed the title [-][MNT]: wheel of 3.5.0 apears to depend on setuptools-scm which apears to be unintentional[/-] [+][MNT]: wheel of 3.5.0 appears to depend on setuptools-scm which appears to be unintentional[/+] on Jun 23, 2025