FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Deprecate/remove maxdict · Issue #22278 · matplotlib/matplotlib · GitHub

Repository navigation

Deprecate/remove maxdict #22278

Closed
Closed

Description

The maxdict in matplotlib's cbook is only used in one place in Matplotlib.

_cached = cbook.maxdict(50)

It can probably be updated to functools.cache now, with some work to figure out exactly where to put the cache decorator.

@greglucas Actually, switching to lru_cache would be a bit annoying, because the caching on fontproperties must be based on hash(fontproperties) (as fontproperties themselves are mutable) but then you can't get back the fontproperties from the hash...
(Again, it may be possible to add more indirection around that but it may not really be worth it for now...)

Originally posted by @anntzer in #22271 (comment)

Activity

  1. timhoffm commented on Jan 21, 2022

    Member

    We can immediately deprecate it, and still have enough time to figure out whether we need it internally or can remove it.

  2. anntzer commented on Jan 28, 2022

    Contributor

    Done by #22271.

  3. added this to the v3.6.0 milestone on Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL