Repository navigation
[ENH]: Angle Annotation #24217
Description
Problem
There is a lengthy example of how to annotate angles, including a custom class to do so, at https://matplotlib.org/devdocs/gallery/text_labels_and_annotations/angle_annotation.html. This class is now being used in #24145 because annotating arrows is kind of complex and also useful.
Proposed solution
I think the class should be pulled into the library so it can be more easily reused. This would involve
- figuring out where in the library class AngleAnnotation([Arc](https://matplotlib.org/devdocs/api/_as_gen/matplotlib.patches.Arc.html#matplotlib.patches.Arc)) should go
- ensuring the annotation is scale invariant, which would fix [Doc]: Example for "Scale invariant angle label" does not scale the arc correctly #22392
- writing tests
- adding a whats new entry
- splitting up https://matplotlib.org/devdocs/gallery/text_labels_and_annotations/angle_annotation.html into reference and gallery docs
Activity
jacoverster commented on Oct 19, 2022
I'd be willing to assist here as well @story645
story645 commented on Oct 19, 2022
Awesome! First we should see though if there's support from other maintainers or if other maintainers oppose this feature.
jklymak commented on Oct 19, 2022
What does this do as the aspect ratio changes? The idea of an angle annotation seems pretty niche and fragile for the main library. Given our experience with arrows I'd be really really cautious about adding something half baked.
timhoffm commented on Oct 21, 2022
I very much have the same concerns as @jklymak. This seems complex and we should not add it if we're not confident that it's "just-works".
timhoffm commented on Feb 2, 2025
This is complex to get right. We won’t provide half-baked solutions. It’s niche and therefore we don’t send time on this. We would accept a PR if it addresses the above concerns.
story645 commented on Feb 3, 2025
@timhoffm why are you closing an issue where you say we'd accept a PR that addresses the concerns of the issue?
timhoffm commented on Feb 3, 2025
This is complex and niche. We should not be doing this and I very much doubt anybody es will. So it’s not worth keeping it open. IMO for an issue to stay open, we should either want this to be done (even though it may be hard and not happen for a long time) or it’s acceptable to be included and there’s a realistic chance that somebody else will meaningfully contribute. Otherwise we just pile up more and more open issues that are not relevant for the future development. Open issues are a curation of the direction of the library. If somebody wants to contribute, and looks for a topic that, they are the place to go. I wouldn’t recommend anybody to work on this, there are much more meaningful topics.
1200 open issues are not helpful. Either we close more aggressively according to my above criteria or we have to better structure and prioritize them #28834.
I left the note for the unlikely case that somebody stumbles over the issue and solves it because they need it so that they are not discouraged from bringing up the topic again.