FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow CircleCI to load version switcher hosted on matplotlib.org · Issue #27861 · matplotlib/matplotlib · GitHub

Repository navigation

Allow CircleCI to load version switcher hosted on matplotlib.org #27861

Closed as not planned

Description

I'm currently trying to bump the version of pydata-sphinx-theme that we're using (#27658), so we can get recent accessibility improvements from the theme. It's not currently possible to load the version switcher hosted at https://matplotlib.org/devdocs/_static/switcher.json on the documentation build that CircleCI generates. The console error is:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://matplotlib.org/devdocs/_static/switcher.json?v3.8.1-1173-gfa55c9f44. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 200.

Is there anyone who has access to the Matplotlib website that can fix this to allow pages served by https://output.circle-artifacts.com to load https://matplotlib.org/devdocs/_static/switcher.json ? If this needs any more debugging, here's a link to the full CircleCI doc build on the PR updating pydata-sphinx-theme.

Activity

  1. tacaswell commented on Mar 4, 2024

    Member

    I'm not sure that we want to open up the holes required to opt out of that CORS protection.

  2. dstansby commented on Mar 4, 2024

    MemberAuthor

    👍 in that case (I have zero knowledge/experience of these things) I'm happy to close this, and work out how to turn off the version switcher in the CircleCI build.

  3. dstansby commented on Mar 5, 2024

    MemberAuthor

    FWIW I worked out how to use the version switcher that circleCI hosts with each artifact upload, so no need for this PR or a workaround on the circleCI builds.

  4. QuLogic commented on Mar 6, 2024

    Member

    Some time ago, I manually allowed this for CircleCI. However, this was not a long-term solution, so it was overwritten the next time we refreshed the server, which is why it stopped working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL