'Figure' object has no attribute '_original_dpi' · Issue #9040 · matplotlib/matplotlib · GitHub

With current master, running any example

python3 histogram_cumulative.py

I get

Traceback (most recent call last):
  File "/home/fariza/workspace/matplotlib/lib/matplotlib/backends/backend_qt5agg.py", line 80, in paintEvent
    self._update_figure_dpi()
  File "/home/fariza/workspace/matplotlib/lib/matplotlib/backends/backend_qt5.py", line 186, in _update_figure_dpi
    dpi = self._dpi_ratio * self.figure._original_dpi
AttributeError: 'Figure' object has no attribute '_original_dpi'
Traceback (most recent call last):
  File "/home/fariza/workspace/matplotlib/lib/matplotlib/backends/backend_qt5agg.py", line 80, in paintEvent
    self._update_figure_dpi()
  File "/home/fariza/workspace/matplotlib/lib/matplotlib/backends/backend_qt5.py", line 186, in _update_figure_dpi
    dpi = self._dpi_ratio * self.figure._original_dpi
AttributeError: 'Figure' object has no attribute '_original_dpi'

It opens the window but the image is black

If I force to use a GTK3 backend I dont get the error and the figure is fine

maybe related to #8052

What sha are you at?

#9002 went in yesterday and may have fixed this.

I just pulled from master (20 min ago)

From git rev-parse HEAD
3769792

I can not reproduce this, I assume it has something to do some subtle ordering in when things are created and when things are attempted to be drawn.

Does applying

20:00 $ git diff
diff --git a/lib/matplotlib/backends/backend_qt5agg.py b/lib/matplotlib/backends/backend_qt5agg.py
index 78d9fdada..85954c003 100644
--- a/lib/matplotlib/backends/backend_qt5agg.py
+++ b/lib/matplotlib/backends/backend_qt5agg.py
@@ -176,7 +176,7 @@ class FigureCanvasQTAggBase(FigureCanvasAgg):
         self.draw()
 
 
-class FigureCanvasQTAgg(FigureCanvasQTAggBase, FigureCanvasQT):
+class FigureCanvasQTAgg(FigureCanvasQT, FigureCanvasQTAggBase):
     """
     The canvas the figure renders into.  Calls the draw and print fig
     methods, creates the renderers, etc.

help?

@tacaswell no, I change the order and it doesn't help.

The FigureCanvasQT.__init__ its not being called.

I think FigureCanvasQTAggBase it's being called directly

@tacaswell if I make the change in backend_qt4agg.py.FigureCanvasQTAgg the error changes to

Traceback (most recent call last):
  File "/home/fariza/workspace/matplotlib/lib/matplotlib/backends/backend_qt5.py", line 309, in resizeEvent
    self.draw_idle()
  File "/home/fariza/workspace/matplotlib/lib/matplotlib/backends/backend_qt5agg.py", line 143, in draw_idle
    if not self._agg_draw_pending:
AttributeError: 'FigureCanvasQTAgg' object has no attribute '_agg_draw_pending'

Why it shows me the error in qt5? if it is qt4 in reality?

Ah! Because the qt4 backend is a sub-class of the qt5 backend. The main differences between them are that qt5 is co-opperative and qt4 is not which mostly shows up in the __init__ method.

import networkx
import matplotlib.backends.backend_qt4agg

def build_inheritance_graph(cls):
    g = networkx.DiGraph()
    todo = set([cls])
    done = set()

    while todo:
        cls = todo.pop()
        for b in cls.__bases__:
            if b not in done:
                todo.add(b)
            g.add_edge(cls.__name__, b.__name__)
    return g

g = build_inheritance_graph(matplotlib.backends.backend_qt5agg.FigureCanvas)
networkx.draw_networkx(g)

will give you a visualization of the MI diagram from these classes (there are 3 diamonds, 1 from us, 1 from Qt and 1 from us + Qt back to object). At least on __init__ is not being properly called on the Qt4 side.

def decorate_init(cls):

    for b in cls.mro():
        decorate(b)

            
def decorate(cls):
    print(cls.__name__)
    if cls is object:
        return

    if 'matplotlib' not in cls.__module__:
        return
    if '__init__' not in cls.__dict__:
        return
    
    orig_init = cls.__dict__['__init__']
    
    def new_init(self, *args, **kwargs):
        print(cls.__module__, cls.__name__)
        return orig_init(self, *args, **kwargs)
    
    cls.__init__ = new_init
 


decorate_init(matplotlib.backends.backend_qt4agg.FigureCanvas)

Will trace through what get called.

I have a patch that works but calls base class inits too many times....

FIX: shim Qt4 and Qt5 together better

How did you install matplotlib? Are you using pyqt4 or pyqt5?

Sorry about the 5.9, specification.

This is the print-out at installation:

 $> python3 setup.py build
Edit setup.cfg to change the build options

BUILDING MATPLOTLIB
            matplotlib: yes [2.1.0]
                python: yes [3.6.3 (default, Oct  9 2017, 08:51:47)  [GCC
                        7.2.0]]
              platform: yes [linux]

REQUIRED DEPENDENCIES AND EXTENSIONS
                 numpy: yes [version 1.13.3]
                   six: yes [using six version 1.11.0]
              dateutil: yes [using dateutil version 2.6.1]
backports.functools_lru_cache: yes [Not required]
          subprocess32: yes [Not required]
                  pytz: yes [using pytz version 2017.2]
                cycler: yes [using cycler version 0.10.0]
               tornado: yes [using tornado version 4.5.2]
             pyparsing: yes [using pyparsing version 2.2.0]
                libagg: yes [pkg-config information for 'libagg' could not
                        be found. Using local copy.]
              freetype: yes [version 2.8.1]
                   png: yes [version 1.6.32]
                 qhull: yes [pkg-config information for 'libqhull' could not
                        be found. Using local copy.]

OPTIONAL SUBPACKAGES
           sample_data: yes [installing]
              toolkits: yes [installing]
                 tests: no  [skipping due to configuration]
        toolkits_tests: no  [skipping due to configuration]

OPTIONAL BACKEND EXTENSIONS
                macosx: no  [Mac OS-X only]
                qt5agg: yes [installing, Qt: 5.7.1, PyQt: 5.7.1; PySide2 not
                        found]
                qt4agg: no  [PySide not found; PyQt4 not found]
               gtk3agg: no  [Requires pygobject to be installed.]
             gtk3cairo: no  [Requires cairocffi or pycairo to be installed.]
                gtkagg: no  [Requires pygtk]
                 tkagg: yes [installing; run-time loading from Python Tcl /
                        Tk]
                 wxagg: no  [requires wxPython]
                   gtk: no  [Requires pygtk]
                   agg: yes [installing]
                 cairo: no  [cairocffi or pycairo not found]
             windowing: no  [Microsoft Windows only]

OPTIONAL LATEX DEPENDENCIES
                dvipng: no
           ghostscript: yes [version 9.20]
                 latex: yes [version 3.14159265]
               pdftops: yes [version 0.48.0]

OPTIONAL PACKAGE DATA
                  dlls: no  [skipping due to configuration]

I just noticed that in fact it is using PyQt 5.9, as I initially wrote. If I do:

>>> import PyQt5.QtCore as q
>>> print(q.PYQT_VERSION_STR)
5.9
>>> print(q.QT_VERSION_STR)
5.7.1

So I guess there is a bug in the QT_VERSION_STR, I will try and report this to their mailing list.

Ahh, no, of course. QT is the parent library, while PYQT is the python wrapper qt.

In fact, I believe this to be a bug in setupext.py, it reads (@line 2077 and 2127)

qt_version = QtCore.QT_VERSION
pyqt_version_str = QtCore.QT_VERSION_STR

while I guess it should read:

qt_version = QtCore.QT_VERSION
pyqt_version_str = QtCore.PYQT_VERSION_STR

What do you think?

I think you're right, would you submit a PR for that fix? Not sure what's going wrong with your original problem, unfortunately.

@zerothi Do you still have this problem with 2.1.1?

Closing as we can not reproduce this with 2.1.1. Please ping to be re-opened if you can still reproduce this issue with the current stable release.

'Figure' object has no attribute '_original_dpi' · Issue #9040 · matplotlib/matplotlib · GitHub

Repository navigation

'Figure' object has no attribute '_original_dpi' #9040

5 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

'Figure' object has no attribute '_original_dpi' · Issue #9040 · matplotlib/matplotlib · GitHub

Repository navigation

'Figure' object has no attribute '_original_dpi' #9040

Description

Activity

fariza commented on Aug 15, 2017

tacaswell commented on Aug 15, 2017

fariza commented on Aug 15, 2017

fariza commented on Aug 15, 2017

tacaswell commented on Aug 16, 2017

fariza commented on Aug 16, 2017

fariza commented on Aug 16, 2017

tacaswell commented on Aug 16, 2017

tacaswell commented on Aug 17, 2017

tacaswell commented on Aug 17, 2017

tacaswell commented on Aug 17, 2017

5 remaining items

tacaswell commented on Oct 12, 2017

zerothi commented on Oct 12, 2017

zerothi commented on Oct 12, 2017

zerothi commented on Oct 12, 2017

zerothi commented on Oct 12, 2017

dopplershift commented on Oct 17, 2017

tacaswell commented on Dec 18, 2017

tacaswell commented on Jan 8, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions