FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

2.1.0 sdist does not allow building docs · Issue #9735 · matplotlib/matplotlib · GitHub

Repository navigation

2.1.0 sdist does not allow building docs #9735

Closed

Description

See issue described at https://mail.python.org/pipermail//matplotlib-devel/2017-November/000895.html

This is due (at least) to an outdated MANIFEST.in (which is missing, for example, INSTALL.rst).

Instead of continually trying to keep MANIFEST.in in sync with the source tree (a never ending task...) I propose to make it include everything, but hook the sdist command to first check that we are in a clean git repo (and ask the user to run git clean -xdf if in a dirty repo, and accept not being able to build an sdist from a non-repo (not sure what the use case is tbh...)).

Or perhaps we can even completely subvert setup.py sdist to run git archive $tag -o dist/matplotlib-$version.tgz --prefix matplotlib-$version.tgz which actually appears to also creates a valid(?) sdist that pip can install (and we can set export-ignore if there are files we don't want to include, see https://git-scm.com/docs/git-archive#ATTRIBUTES).

Activity

  1. added this to the v2.1.1 milestone on Nov 10, 2017
  2. added a commit that references this issue on Nov 13, 2017
    960f7e6
  3. dopplershift commented on Nov 14, 2017

    Contributor

    Was this fixed by #9768 ?

  4. anntzer commented on Nov 14, 2017

    ContributorAuthor

    Someone needs to actually try it... (actually I think one of the docs CI builds should try to build everything from a sdist).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL