Commit 23bd58d
committed
File tree
- src
- client/common/application
- test/common/application/commands
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -87,7 +87,7 @@ export interface ICommandNameArgumentTypeMapping extends ICommandNameWithoutArgu | |||
| 87 | 87 | ['jupyter.opennotebook']: [undefined | Uri, undefined | CommandSource]; | |
| 88 | 88 | ['jupyter.runallcells']: [Uri]; | |
| 89 | 89 | ['extension.open']: [string]; | |
| 90 | - ['workbench.action.openIssueReporter']: [{ extensionId: string; issueBody: string }]; | ||
| 90 | + ['workbench.action.openIssueReporter']: [{ extensionId: string; issueBody: string; extensionData?: string }]; | ||
| 91 | 91 | [Commands.GetSelectedInterpreterPath]: [{ workspaceFolder: string } | string[]]; | |
| 92 | 92 | [Commands.TriggerEnvironmentSelection]: [undefined | Uri]; | |
| 93 | 93 | [Commands.Start_Native_REPL]: [undefined | Uri]; | |
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -126,17 +126,17 @@ suite('Report Issue Command', () => { | |||
| 126 | 126 | ); | |
| 127 | 127 | const expectedData = fs.readFileSync(userDataTemplatePath, 'utf8'); | |
| 128 | 128 | ||
| 129 | - const args: [string, { extensionId: string; issueBody: string; data: string }] = capture< | ||
| 129 | + const args: [string, { extensionId: string; issueBody: string; extensionData: string }] = capture< | ||
| 130 | 130 | AllCommands, | |
| 131 | - { extensionId: string; issueBody: string; data: string } | ||
| 131 | + { extensionId: string; issueBody: string; extensionData: string } | ||
| 132 | 132 | >(cmdManager.executeCommand).last(); | |
| 133 | 133 | ||
| 134 | 134 | verify(cmdManager.registerCommand(Commands.ReportIssue, anything(), anything())).once(); | |
| 135 | 135 | verify(cmdManager.executeCommand('workbench.action.openIssueReporter', anything())).once(); | |
| 136 | 136 | expect(args[0]).to.be.equal('workbench.action.openIssueReporter'); | |
| 137 | - const { issueBody, data } = args[1]; | ||
| 137 | + const { issueBody, extensionData } = args[1]; | ||
| 138 | 138 | expect(issueBody).to.be.equal(expectedIssueBody); | |
| 139 | - expect(data).to.be.equal(expectedData); | ||
| 139 | + expect(extensionData).to.be.equal(expectedData); | ||
| 140 | 140 | }); | |
| 141 | 141 | ||
| 142 | 142 | test('Test if issue body is filled when only including settings which are explicitly set', async () => { | |
@@ -167,16 +167,16 @@ suite('Report Issue Command', () => { | |||
| 167 | 167 | ); | |
| 168 | 168 | const expectedData = fs.readFileSync(userDataTemplatePath, 'utf8'); | |
| 169 | 169 | ||
| 170 | - const args: [string, { extensionId: string; issueBody: string; data: string }] = capture< | ||
| 170 | + const args: [string, { extensionId: string; issueBody: string; extensionData: string }] = capture< | ||
| 171 | 171 | AllCommands, | |
| 172 | - { extensionId: string; issueBody: string; data: string } | ||
| 172 | + { extensionId: string; issueBody: string; extensionData: string } | ||
| 173 | 173 | >(cmdManager.executeCommand).last(); | |
| 174 | 174 | ||
| 175 | 175 | verify(cmdManager.executeCommand('workbench.action.openIssueReporter', anything())).once(); | |
| 176 | 176 | expect(args[0]).to.be.equal('workbench.action.openIssueReporter'); | |
| 177 | - const { issueBody, data } = args[1]; | ||
| 177 | + const { issueBody, extensionData } = args[1]; | ||
| 178 | 178 | expect(issueBody).to.be.equal(expectedIssueBody); | |
| 179 | - expect(data).to.be.equal(expectedData); | ||
| 179 | + expect(extensionData).to.be.equal(expectedData); | ||
| 180 | 180 | }); | |
| 181 | 181 | test('Should send telemetry event when run Report Issue Command', async () => { | |
| 182 | 182 | const sendTelemetryStub = sinon.stub(Telemetry, 'sendTelemetryEvent'); | |
0 commit comments