Turn-off experiment logs when telemetry is disabled (#17908) · minsa110/vscode-python@970bed9 · GitHub

minsa110 / vscode-python Public

forked from microsoft/vscode-python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 970bed9

Browse filesBrowse the repository at this point in the historyBrowse files

karthiknadig

authored

Turn-off experiment logs when telemetry is disabled (microsoft#17908)

* Turnoff experiment logs when telemtry is diabled * Fix tests

1 parent 2ee548c commit 970bed9
Copy full SHA for 970bed9

2 files changed

+14-1Lines changed: 14 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/ISSUE_TEMPLATE
  • 1_new_bug_report.yml
• src/client/common/experiments
  • service.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/ISSUE_TEMPLATE/1_new_bug_report.yml‎

Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/1_new_bug_report.yml

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -40,7 +40,7 @@ body:
40	40	attributes:
41	41	label: Language server
42	42	description: 'The value of the `python.languageServer` setting'
43		- options: ['Default', 'Pylance', 'Jedi', 'Disabled']
	43	+ options: ['Default', 'Pylance', 'Jedi', 'None or Disabled']
44	44	validations:
45	45	required: true
46	46	- type: textarea

Collapse file

‎src/client/common/experiments/service.ts‎

Copy file name to clipboardExpand all lines: src/client/common/experiments/service.ts

+13Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -142,6 +142,19 @@ export class ExperimentService implements IExperimentService {
142	142	}
143	143
144	144	private logExperiments() {
	145	+ const telemetrySettings = this.workspaceService.getConfiguration('telemetry');
	146	+ if (telemetrySettings && telemetrySettings.get<boolean>('enableTelemetry') === false) {
	147	+ this.output.appendLine('Telemetry is disabled');
	148	+ this.output.appendLine('Experiments are disabled');
	149	+ return;
	150	+ }
	151	+
	152	+ if (telemetrySettings && telemetrySettings.get<string>('telemetryLevel') === 'off') {
	153	+ this.output.appendLine('Telemetry level is off');
	154	+ this.output.appendLine('Experiments are disabled');
	155	+ return;
	156	+ }
	157	+
145	158	if (this._optOutFrom.includes('All')) {
146	159	// We prioritize opt out first
147	160	this.output.appendLine(Experiments.optedOutOf().format('All'));

0 commit comments

Comments

0 (0)