ci: test against per-module minimum go version - #215
Draft
thaJeztah wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Go-setup action allow specifying both a "go-version" and "go-version-file", in which case it falls back to the version-file if "go-version" is empty. This allows us to iterate over all modules, and run CI on the oldest supported Go version for each (in addition to "oldstable" and "stable"). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
kolyshkin
reviewed
May 27, 2026
Comment thread
.github/workflows/test.yml
| timeout-minutes: 10 # guardrails timeout for the whole job | ||
|
|
||
| env: | ||
| GOTOOLCHAIN: local |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Is this a request for go to NOT download another go version? If yes, why do we need it here? I mean, it may only happen if we have go.mod with go version less than specified here, which should never be the case.
Or is this something more generic, like "don't download anything" and omitting it may mask some issue?
Sorry, something went wrong.
kolyshkin
reviewed
May 27, 2026
Comment thread
.github/workflows/test.yml
Comment on lines
+25
to
+34
| - atomicwriter | ||
| - capability | ||
| - mount | ||
| - mountinfo | ||
| - reexec | ||
| - sequential | ||
| - signal | ||
| - symlink | ||
| - user | ||
| - userns |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I like the way it is used here. I don't like that we have to also list all the modules in the top-level Makefile.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go-setup action allow specifying both a "go-version" and "go-version-file", in which case it falls back to the version-file if "go-version" is empty.
This allows us to iterate over all modules, and run CI on the oldest supported Go version for each (in addition to "oldstable" and "stable").