Keep the stale-baseline guard fail-closed under pipefail · modelcontextprotocol/python-sdk@a2072c3 · GitHub

modelcontextprotocol / python-sdk Public

• Notifications You must be signed in to change notification settings
• Fork 3.8k
• Star 24.1k

• Code
• Issues 205
• Pull requests 184
• Actions
• Projects
• Security and quality 6
• Insights

Additional navigation options

Commit a2072c3

Browse filesBrowse the repository at this point in the historyBrowse files

maxisbey

committed

Keep the stale-baseline guard fail-closed under pipefail

grep -q quitting at the first match SIGPIPEs the printf feeding it; with pipefail the pipeline reports 141 and the guard is skipped exactly when the pattern is present. A here-string has no writer to kill.

1 parent b4558ce commit a2072c3
Copy full SHA for a2072c3

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/actions/conformance
  • run-client.sh

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/actions/conformance/run-client.sh‎

Copy file name to clipboardExpand all lines: .github/actions/conformance/run-client.sh

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -43,7 +43,9 @@ for scenario in "${scenarios[@]}"; do
43	43	done
44	44
45	45	# A stale baseline entry is a configuration error a solo rerun cannot excuse.
46		- if printf '%s\n' "$plain" | grep -q '^Stale baseline entries'; then
	46	+ # Here-string, not a pipe: grep -q quitting early would SIGPIPE printf and,
	47	+ # under pipefail, skip this guard exactly when the pattern is present.
	48	+ if grep -q '^Stale baseline entries' <<<"$plain"; then
47	49	echo "Suite also reported stale baseline entries; not retrying." >&2
48	50	exit "$rc"
49	51	fi

0 commit comments

Comments

0 (0)