bpo-33391: Fix refleak in set_symmetric_difference (GH-6670) · native-api/cpython@491bbed · GitHub

1. native-api
2. cpython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 491bbed

Browse filesBrowse the repository at this point in the historyBrowse files

lekma

authored and

methane

committed

bpo-33391: Fix refleak in set_symmetric_difference (pythonGH-6670)

1 parent fc6aa28 commit 491bbed
Copy full SHA for 491bbed

2 files changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Misc/NEWS.d/next/Core and Builtins
  • 2018-05-02-08-36-03.bpo-33391.z4a7rb.rst
• Objects
  • setobject.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Misc/NEWS.d/next/Core and Builtins/2018-05-02-08-36-03.bpo-33391.z4a7rb.rst‎

Copy file name to clipboard

+1Lines changed: 1 addition & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -0,0 +1 @@
	1	+ Fix a leak in set_symmetric_difference().

Collapse file

‎Objects/setobject.c‎

Copy file name to clipboardExpand all lines: Objects/setobject.c

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1744,8 +1744,10 @@ set_symmetric_difference(PySetObject *so, PyObject *other)
1744	1744	if (otherset == NULL)
1745	1745	return NULL;
1746	1746	rv = set_symmetric_difference_update(otherset, (PyObject *)so);
1747		- if (rv == NULL)
	1747	+ if (rv == NULL) {
	1748	+ Py_DECREF(otherset);
1748	1749	return NULL;
	1750	+ }
1749	1751	Py_DECREF(rv);
1750	1752	return (PyObject *)otherset;
1751	1753	}

0 commit comments

Comments

0 (0)