bpo-35766 follow-up: Add an error check to new_type_comment() (#11766) · native-api/cpython@4b250fc · GitHub

1. native-api
2. cpython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 4b250fc

Browse filesBrowse the repository at this point in the historyBrowse files

gvanrossum

authored

bpo-35766 follow-up: Add an error check to new_type_comment() (python#11766)

If PyUnicode_DecodeUTF8() returns NULL, PyArena_AddPyObject() would crash. Found by @msullivan for python/typed_ast#93.

1 parent 537b6ca commit 4b250fc
Copy full SHA for 4b250fc

1 file changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Python
  • ast.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Python/ast.c‎

Copy file name to clipboardExpand all lines: Python/ast.c

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -702,6 +702,8 @@ static string
702	702	new_type_comment(const char *s, struct compiling *c)
703	703	{
704	704	PyObject *res = PyUnicode_DecodeUTF8(s, strlen(s), NULL);
	705	+ if (res == NULL)
	706	+ return NULL;
705	707	if (PyArena_AddPyObject(c->c_arena, res) < 0) {
706	708	Py_DECREF(res);
707	709	return NULL;

0 commit comments

Comments

0 (0)