This repository was archived by the owner on Apr 7, 2025. It is now read-only.
fix(homepage video): clean up loading visuals - #453
Merged
jbeveland27 merged 4 commits intoJun 17, 2020
Merged
jbeveland27 merged 4 commits into
jbeveland27 merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
added 3 commits
June 17, 2020 07:36
- Set placeholder for desktop video - Replace old video with new one on mobile - minor style adjustments on the homepage Resolves newrelic#447
- Set a bg color on the video on desktop so that when the page loads you don't see all of the guts of how that video element is put together.
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 17, 2020
## [1.0.5](v1.0.4...v1.0.5) (2020-06-17) ### Bug Fixes * **homepage video:** clean up loading visuals ([#453](#453)) ([620b820](620b820))
Copy link
Copy Markdown
Contributor
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set a bg color on the video on desktop so that when the page loads you don't see all of the guts of how that video element is put together.
Not sure why there's an extra commit for fixing the mobile video in this list. Clearly it's not doing anything.