FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Move some worker-and-example-only dependencies out of sdk · ngandy/DataflowJavaSDK@24288e7 · GitHub

  1. ngandy
  2. DataflowJavaSDK

Repository navigation

Commit 24288e7

Browse files
kennknowles
authored and
davorbonaci
committed
Move some worker-and-example-only dependencies out of sdk
Following the separation of the worker module, running $ mvn dependency:analyze -pl sdk yields [WARNING] Used undeclared dependencies found: [WARNING] com.google.code.findbugs:jsr305:jar:3.0.1:compile [WARNING] javax.xml.stream:stax-api:jar:1.0-2:compile [WARNING] com.google.http-client:google-http-client:jar:1.21.0:compile [WARNING] Unused declared dependencies found: [WARNING] org.eclipse.jetty:jetty-servlet:jar:9.2.10.v20150310:compile [WARNING] org.codehaus.woodstox:woodstox-core-asl:jar:4.1.2:compile [WARNING] org.eclipse.jetty:jetty-server:jar:9.2.10.v20150310:compile [WARNING] javax.servlet:javax.servlet-api:jar:3.1.0:compile [WARNING] org.tukaani:xz:jar:1.5:compile This change removes unused dependencies. The `xz` and `woodstox` dependencies are for optional features of AvroSource and XmlSource. ----Release Notes---- [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=115300250
1 parent 7871cbb commit 24288e7

4 files changed

Lines changed: 30 additions & 18 deletions

File tree

‎examples/pom.xml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -484,6 +484,12 @@
484484
<scope>runtime</scope>
485485
</dependency>
486486

487+
<dependency>
488+
<groupId>javax.servlet</groupId>
489+
<artifactId>javax.servlet-api</artifactId>
490+
<version>3.1.0</version>
491+
</dependency>
492+
487493
<!-- Hamcrest and JUnit are required dependencies of DataflowAssert,
488494
which is used in the main code of DebuggingWordCount example. -->
489495

‎maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,12 @@
166166
<version>18.0</version>
167167
</dependency>
168168

169+
<dependency>
170+
<groupId>javax.servlet</groupId>
171+
<artifactId>javax.servlet-api</artifactId>
172+
<version>3.1.0</version>
173+
</dependency>
174+
169175
<!-- Add slf4j API frontend binding with JUL backend -->
170176
<dependency>
171177
<groupId>org.slf4j</groupId>

‎sdk/pom.xml‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -640,24 +640,6 @@
640640
<version>${joda.version}</version>
641641
</dependency>
642642

643-
<dependency>
644-
<groupId>org.eclipse.jetty</groupId>
645-
<artifactId>jetty-server</artifactId>
646-
<version>9.2.10.v20150310</version>
647-
</dependency>
648-
649-
<dependency>
650-
<groupId>org.eclipse.jetty</groupId>
651-
<artifactId>jetty-servlet</artifactId>
652-
<version>9.2.10.v20150310</version>
653-
</dependency>
654-
655-
<dependency>
656-
<groupId>javax.servlet</groupId>
657-
<artifactId>javax.servlet-api</artifactId>
658-
<version>3.1.0</version>
659-
</dependency>
660-
661643
<!--
662644
To use com.google.cloud.dataflow.io.XmlSource, please explicitly declare
663645
the following two dependencies.

‎worker/pom.xml‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,24 @@
245245
<scope>compile</scope>
246246
</dependency>
247247

248+
<dependency>
249+
<groupId>org.eclipse.jetty</groupId>
250+
<artifactId>jetty-server</artifactId>
251+
<version>9.2.10.v20150310</version>
252+
</dependency>
253+
254+
<dependency>
255+
<groupId>org.eclipse.jetty</groupId>
256+
<artifactId>jetty-servlet</artifactId>
257+
<version>9.2.10.v20150310</version>
258+
</dependency>
259+
260+
<dependency>
261+
<groupId>javax.servlet</groupId>
262+
<artifactId>javax.servlet-api</artifactId>
263+
<version>3.1.0</version>
264+
</dependency>
265+
248266
<!-- test dependencies -->
249267
<dependency>
250268
<groupId>org.hamcrest</groupId>

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL