Path issues windows #522
Description
Activity
Git uses forward slashes internally, we should never ever change them to be back slashes.
ahh ok, so what is the recommend approach on windows then? Just not use the nodejs path module?
Node normalizes paths for you. Can you paste an example where this isn't true?
That is exactly the problem in this case - node normalizes the path to windows style, so path\to\file but git uses path/to/file.
I think this is out of the scope of NodeGit, which is attempting to bind 1:1 to libgit2 and where possible provide some convenience over repetitive tasks. By allowing either Unix or Windows style, we'd be breaking a convention from within Git.
You can normalize with a simple enough replace regex: path = path.replace(/\\/g, '/');
I agree that it's out of scope, but just a small suggestion, @Globegitter could you not call path.normalize on the returned value, like so?
path.normalize(patch.oldFile().path());
When using patch.oldFile().path(); as per example seen here https://github.com/nodegit/nodegit/blob/master/examples/walk-history-for-file.js#L27 the path returned here stays with forward-slashes (/), where-as when you use nodejs' path it returns backwards-slashes. This now makes comparing part of the path quite hard.
The workaround I currently have it just to replace all slashes in the path string, so they match.