lib: add unsubscribe method to non-active DC channels · nodejs/node@004eafb · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 004eafb

Browse filesBrowse the repository at this point in the historyBrowse files

simon-id

authored and

richardlau

committed

lib: add unsubscribe method to non-active DC channels

PR-URL: #40433 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

1 parent 625be75 commit 004eafb
Copy full SHA for 004eafb

2 files changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • diagnostics_channel.md
• lib
  • diagnostics_channel.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/diagnostics_channel.md‎

Copy file name to clipboardExpand all lines: doc/api/diagnostics_channel.md

+1-1Lines changed: 1 addition & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -162,7 +162,7 @@ added:
162	162	changes:
163	163	- version: REPLACEME
164	164	pr-url: https://github.com/nodejs/node/pull/40433
165		- description: Added return value.
	165	+ description: Added return value. Added to channels without subscribers.
166	166	-->
167	167
168	168	* `onMessage` {Function} The previous subscribed handler to remove

Collapse file

‎lib/diagnostics_channel.js‎

Copy file name to clipboardExpand all lines: lib/diagnostics_channel.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -81,6 +81,10 @@ class Channel {
81	81	this.subscribe(subscription);
82	82	}
83	83
	84	+ unsubscribe() {
	85	+ return false;
	86	+ }
	87	+
84	88	get hasSubscribers() {
85	89	return false;
86	90	}

0 commit comments

Comments

0 (0)