Commit 0094a8d
committed
http: add callback is function check
We were checking that the callback existed, but not
checking that it was a function. In `setTimeout`, if
callback is truthy but not a function, throw a
TypeError
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #30901 parent 05d424c commit 0094a8d
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -89,8 +89,12 @@ exports.OutgoingMessage = OutgoingMessage; | |||
| 89 | 89 | ||
| 90 | 90 | ||
| 91 | 91 | OutgoingMessage.prototype.setTimeout = function(msecs, callback) { | |
| 92 | - if (callback) | ||
| 92 | + | ||
| 93 | + if (callback) { | ||
| 94 | + if (typeof callback !== 'function') | ||
| 95 | + throw new TypeError('callback must be a function'); | ||
| 93 | 96 | this.on('timeout', callback); | |
| 97 | + } | ||
| 94 | 98 | ||
| 95 | 99 | if (!this.socket) { | |
| 96 | 100 | this.once('socket', function(socket) { | |
0 commit comments