Commit 009ab4d
test: deflake fs-promises-watch
Change the contents of the file every 100 milliseconds until the watcher
notices the change. This is already done in the callback based version
of the test (`test-fs-watch.js`).
Fixes: #37637
PR-URL: #40863
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>1 parent 878ba91 commit 009ab4d
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -47,9 +47,11 @@ for (const testCase of kCases) { | |||
| 47 | 47 | const content1 = Date.now() + testCase.fileName.toLowerCase().repeat(1e4); | |
| 48 | 48 | fs.writeFileSync(testCase.filePath, content1); | |
| 49 | 49 | ||
| 50 | + let interval; | ||
| 50 | 51 | async function test() { | |
| 51 | 52 | const watcher = watch(testCase[testCase.field]); | |
| 52 | 53 | for await (const { eventType, filename } of watcher) { | |
| 54 | + clearInterval(interval); | ||
| 53 | 55 | assert.strictEqual(['rename', 'change'].includes(eventType), true); | |
| 54 | 56 | assert.strictEqual(filename, testCase.fileName); | |
| 55 | 57 | break; | |
@@ -64,10 +66,10 @@ for (const testCase of kCases) { | |||
| 64 | 66 | ||
| 65 | 67 | // Long content so it's actually flushed. toUpperCase so there's real change. | |
| 66 | 68 | const content2 = Date.now() + testCase.fileName.toUpperCase().repeat(1e4); | |
| 67 | - setImmediate(() => { | ||
| 69 | + interval = setInterval(() => { | ||
| 68 | 70 | fs.writeFileSync(testCase.filePath, ''); | |
| 69 | 71 | fs.writeFileSync(testCase.filePath, content2); | |
| 70 | - }); | ||
| 72 | + }, 100); | ||
| 71 | 73 | ||
| 72 | 74 | test().then(common.mustCall()); | |
| 73 | 75 | } | |
0 commit comments