Commit 00b629b
doc: note that linting is required in releases.md
Refs: #18769
PR-URL: #18776
Refs: #18769
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 15754e6 commit 00b629b
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -397,6 +397,9 @@ Cherry-pick the release commit to `master`. After cherry-picking, edit | |||
| 397 | 397 | `src/node_version.h` to ensure the version macros contain whatever values were | |
| 398 | 398 | previously on `master`. `NODE_VERSION_IS_RELEASE` should be `0`. | |
| 399 | 399 | ||
| 400 | + Run `make lint-md-build; make lint` before pushing to `master`, to make sure the | ||
| 401 | + Changelog formatting passes the lint rules on `master`. | ||
| 402 | + | ||
| 400 | 403 | ### 12. Promote and Sign the Release Builds | |
| 401 | 404 | ||
| 402 | 405 | **It is important that the same individual who signed the release tag be the one | |
0 commit comments