Commit 0127c2b
test: fix test-dns.js flakiness
Use empty string instead of `www.google.com` for tests where we are just
doing parameter evaluation. This will avoid DNS lookups which appear to
be causing flakiness on Raspberry Pi devices in CI.
PR-URL: #5996
Fixes: #5554
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 6052ced commit 0127c2b
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,8 +1,8 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | 2 | require('../common'); | |
| 3 | - var assert = require('assert'); | ||
| 3 | + const assert = require('assert'); | ||
| 4 | 4 | ||
| 5 | - var dns = require('dns'); | ||
| 5 | + const dns = require('dns'); | ||
| 6 | 6 | ||
| 7 | 7 | var existing = dns.getServers(); | |
| 8 | 8 | assert(existing.length); | |
@@ -121,27 +121,27 @@ assert.doesNotThrow(function() { | |||
| 121 | 121 | }); | |
| 122 | 122 | ||
| 123 | 123 | assert.doesNotThrow(function() { | |
| 124 | - dns.lookup('www.google.com', { | ||
| 124 | + dns.lookup('', { | ||
| 125 | 125 | family: 4, | |
| 126 | 126 | hints: 0 | |
| 127 | 127 | }, noop); | |
| 128 | 128 | }); | |
| 129 | 129 | ||
| 130 | 130 | assert.doesNotThrow(function() { | |
| 131 | - dns.lookup('www.google.com', { | ||
| 131 | + dns.lookup('', { | ||
| 132 | 132 | family: 6, | |
| 133 | 133 | hints: dns.ADDRCONFIG | |
| 134 | 134 | }, noop); | |
| 135 | 135 | }); | |
| 136 | 136 | ||
| 137 | 137 | assert.doesNotThrow(function() { | |
| 138 | - dns.lookup('www.google.com', { | ||
| 138 | + dns.lookup('', { | ||
| 139 | 139 | hints: dns.V4MAPPED | |
| 140 | 140 | }, noop); | |
| 141 | 141 | }); | |
| 142 | 142 | ||
| 143 | 143 | assert.doesNotThrow(function() { | |
| 144 | - dns.lookup('www.google.com', { | ||
| 144 | + dns.lookup('', { | ||
| 145 | 145 | hints: dns.ADDRCONFIG | dns.V4MAPPED | |
| 146 | 146 | }, noop); | |
| 147 | 147 | }); | |
0 commit comments