| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,202 @@ | |||
| 1 | + # Node Foundation CTC Meeting 2016-07-20 | ||
| 2 | + | ||
| 3 | + ## Links | ||
| 4 | + | ||
| 5 | + * **Audio Recording**: TBP | ||
| 6 | + * **GitHub Issue**: https://github.com/nodejs/node/issues/7809 | ||
| 7 | + * **Minutes Google Doc**: <https://docs.google.com/document/d/1Gr1XX-DuzgGXON5uAzrZHjWwXoQ4AIJEAJ2DK5jNmp4> | ||
| 8 | + * _Previous Minutes Google Doc: <https://docs.google.com/document/d/1fP9_ZNcPoFh2VWCgUFu9-rDiDcMP88vhCC_oX6Aj528>_ | ||
| 9 | + | ||
| 10 | + ## Present | ||
| 11 | + | ||
| 12 | + * Anna Henningsen @addaleax (observer) | ||
| 13 | + * Ben Noordhuis @bnoordhuis (CTC) | ||
| 14 | + * Сковорода Никита Андреевич @ChALkeR (CTC) | ||
| 15 | + * Colin Ihrig @cjihrig (CTC) | ||
| 16 | + * Evan Lucas @evanlucas (CTC) | ||
| 17 | + * Jeremiah Senkpiel @Fishrock123 (CTC) | ||
| 18 | + * Josh Gavant @joshgav (observer/Microsoft) | ||
| 19 | + * Michael Dawson @mhdawson (CTC) | ||
| 20 | + * Julien Gilli @misterdjules (CTC) | ||
| 21 | + * Brian White @mscdex (CTC) | ||
| 22 | + * Ali Ijaz Sheikh @ofrobots (CTC) | ||
| 23 | + * Alexis Campailla @orangemocha (CTC) | ||
| 24 | + * Rod Vagg @rvagg (CTC) | ||
| 25 | + * Seth Thompson @s3ththompson (observer/Google) | ||
| 26 | + * Shigeki Ohtsu @shigeki (CTC) | ||
| 27 | + * Steven R Loomis @srl295 (observer/IBM/ICU) | ||
| 28 | + * Myles Borins @TheAlphaNerd (observer) | ||
| 29 | + * Trevor Norris @trevnorris (CTC) | ||
| 30 | + * Rich Trott @Trott (CTC) | ||
| 31 | + | ||
| 32 | + | ||
| 33 | + ## Standup | ||
| 34 | + | ||
| 35 | + * Anna Henningsen @addaleax (observer) | ||
| 36 | + * Issues & PRs | ||
| 37 | + * looking into porting JS-based realpath to C | ||
| 38 | + * Ben Noordhuis @bnoordhuis (CTC) | ||
| 39 | + * The usual (PR review and comment) | ||
| 40 | + * Updating code base to do less manual memory management. PR coming soon. | ||
| 41 | + * Сковорода Никита Андреевич @ChALkeR (CTC) | ||
| 42 | + * Some initial work on docs linting. | ||
| 43 | + * Some comments on issues and PRs. | ||
| 44 | + * Colin Ihrig @cjihrig (CTC) | ||
| 45 | + * Reviewed issues and PRs | ||
| 46 | + * Opened PRs | ||
| 47 | + * Evan Lucas @evanlucas (CTC) | ||
| 48 | + * working on v6.3.1 release | ||
| 49 | + * working on repl bugfix | ||
| 50 | + * Jeremiah Senkpiel @Fishrock123 (CTC) | ||
| 51 | + * Did some timers review for https://github.com/nodejs/node/commit/5aac4c42da104c30d8f701f1042d61c2f06b7e6c | ||
| 52 | + * Clearing out some other old stuff I’ve assigned myself to | ||
| 53 | + * Josh Gavant @joshgav (observer/Microsoft) | ||
| 54 | + * Internal Microsoft work. | ||
| 55 | + * Michael Dawson @mhdawson (CTC) | ||
| 56 | + * Misc issues with PPC machines, added new PPC | ||
| 57 | + machines from newer openstack | ||
| 58 | + * Working with Ian/Sampson on ABI stable abi, status | ||
| 59 | + update at API WG meeting | ||
| 60 | + * Working with Richard/Howard on post-mortem activities, | ||
| 61 | + post-mortem WG meeting this week. | ||
| 62 | + * Misc reviews/lands | ||
| 63 | + * Reading/keeping up/commenting on issues | ||
| 64 | + * Getting ready for Node Summit talk. | ||
| 65 | + * Julien Gilli @misterdjules (CTC) | ||
| 66 | + * Looking forward to getting more involved again | ||
| 67 | + * Investigating timers bug. Looking for someone to mentor on it | ||
| 68 | + * Reviewing and commenting on pull requests | ||
| 69 | + * Brian White @mscdex (CTC) | ||
| 70 | + * Diving deep into reworking API docs | ||
| 71 | + * Reviewing PRs, commenting on issues | ||
| 72 | + * Ali Ijaz Sheikh @ofrobots (CTC) | ||
| 73 | + * shepherding some V8 backports, v8_inspector license issue and roll | ||
| 74 | + * Alexis Campailla @orangemocha (CTC) | ||
| 75 | + * Nothing to report. | ||
| 76 | + * Rod Vagg @rvagg (CTC) | ||
| 77 | + * Usual administrative stuff, some build maintenance | ||
| 78 | + * Seth Thompson @s3ththompson (observer/Google) | ||
| 79 | + * Setting priorities for the next quarter. | ||
| 80 | + * Team is continuing work on v8_inspector. | ||
| 81 | + * Migrating v8_inspector into V8 itself. | ||
| 82 | + * Shigeki Ohtsu @shigeki (CTC) | ||
| 83 | + * Nothing special. Working internal jobs. | ||
| 84 | + * Steven R Loomis @srl295 (observer/IBM/ICU) | ||
| 85 | + * Nodesummit prep… | ||
| 86 | + * Myles Borins @TheAlphaNerd (observer) | ||
| 87 | + * v4.5.0-rc.2 released | ||
| 88 | + * Email sent to npm team | ||
| 89 | + * Trevor Norris @trevnorris (CTC) | ||
| 90 | + * realpath fix | ||
| 91 | + * Rich Trott @Trott (CTC) | ||
| 92 | + * CTC governance doc updates | ||
| 93 | + * onboarded @andrasq, will set up something with @princejwesley next, open to other nominations for after that | ||
| 94 | + * eliminating more flaky tests (IT NEVER ENDS!!!!11!!!) | ||
| 95 | + | ||
| 96 | + | ||
| 97 | + ## Agenda | ||
| 98 | + | ||
| 99 | + Extracted from **ctc-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. | ||
| 100 | + | ||
| 101 | + ### nodejs/node | ||
| 102 | + | ||
| 103 | + * [meta] realpath issues in v6 [#7726](https://github.com/nodejs/node/issues/7726) | ||
| 104 | + * v4.5.0 proposal [#7688](https://github.com/nodejs/node/pull/7688) | ||
| 105 | + * http: don't inherit from Object.prototype [#6102](https://github.com/nodejs/node/pull/6102) | ||
| 106 | + | ||
| 107 | + ### nodejs/node-eps | ||
| 108 | + | ||
| 109 | + * proposal: WHATWG URL standard implementation [#28](https://github.com/nodejs/node-eps/pull/28) | ||
| 110 | + | ||
| 111 | + ## Previous Meeting | ||
| 112 | + | ||
| 113 | + * build: drop support for VS 2013 in v7 [#7484](https://github.com/nodejs/node/pull/7484) | ||
| 114 | + | ||
| 115 | + * Node 6 fs.realpath behavior changes [#7175](https://github.com/nodejs/node/pull/7175) | ||
| 116 | + | ||
| 117 | + * http: don't inherit from Object.prototype [#6102](https://github.com/nodejs/node/pull/6102) | ||
| 118 | + | ||
| 119 | + * v4.5.0 proposal [#7688](https://github.com/nodejs/node/pull/7688) | ||
| 120 | + | ||
| 121 | + * proposal: WHATWG URL standard implementation [#28](https://github.com/nodejs/node-eps/pull/28) | ||
| 122 | + | ||
| 123 | + ## Minutes | ||
| 124 | + | ||
| 125 | + ### [meta] realpath issues in v6 [#7726](https://github.com/nodejs/node/issues/7726) | ||
| 126 | + | ||
| 127 | + @rvagg: some discussion of reversion to v5 behavior, i.e. JS implementation rather than libuv implementation. | ||
| 128 | + | ||
| 129 | + @trevnorris: looks like everybody’s leaning towards a full revert (or at least a partial revert). I don’t like this plan but will go along. | ||
| 130 | + | ||
| 131 | + @addaleax: Unfortunate to have to do full revert for *nix systems. But having alternate impl for Windows increases maintenance costs. | ||
| 132 | + | ||
| 133 | + As part of the new implementation, the `cache` parameter was removed from the method. It was created to improve perf for the JS impl but is considered less necessary since the native impl performs better anyway. | ||
| 134 | + | ||
| 135 | + Should we reinstate the `cache` parameter as part of the revert? Would this be a semver-major again? Does caching in the JS impl provide a significant perf benefit? | ||
| 136 | + | ||
| 137 | + @addaleax: Benchmarking fs perf will show how much benefit the caching capability in libuv provides. | ||
| 138 | + | ||
| 139 | + @mhdawson: we run two benchmarks nightly: one with caching and one without. | ||
| 140 | + | ||
| 141 | + @orangemocha: It seems okay to have two impl’s, one for Windows and one for *nix, increased maintenance surface isn’t a concern, libuv manages libuv impl. | ||
| 142 | + | ||
| 143 | + @rvagg: As we move v6 to LTS it would be best to have a known-good implementation. So would prefer a full revert, then fix libuv impl independently, then re-integrate. | ||
| 144 | + | ||
| 145 | + @thealphanerd: Could we provide both interfaces? Revert the primary one to original behavior and add a second one with libuv behavior? | ||
| 146 | + | ||
| 147 | + @rvagg: Still doesn’t address breaking change in Windows. | ||
| 148 | + | ||
| 149 | + @fishrock123: also in favor of reverting. This has been going on for a long time, best to revert and then fix. | ||
| 150 | + | ||
| 151 | + @orangemocha: should not compromise correctness for performance. | ||
| 152 | + | ||
| 153 | + @trevnorris: caching could be separated from fs API. For example, it could be part of `module` module. | ||
| 154 | + | ||
| 155 | + @rvagg: This is why I’m in favor of a full reversion. These other discussions may continue for a month and we need to correct problem now. | ||
| 156 | + | ||
| 157 | + @thealphanerd: do we have a list of the original bugs the libuv patch addressed? | ||
| 158 | + | ||
| 159 | + @saghul has a list. | ||
| 160 | + | ||
| 161 | + @rvagg: back to github for now. | ||
| 162 | + | ||
| 163 | + **Next steps**: continue discussion in GH. | ||
| 164 | + | ||
| 165 | + ### v4.5.0 proposal [#7688](https://github.com/nodejs/node/pull/7688) | ||
| 166 | + | ||
| 167 | + @thealphanerd is raising visibility for tests and feedback. | ||
| 168 | + | ||
| 169 | + @misterdjules may have some testers. | ||
| 170 | + | ||
| 171 | + ### http: don't inherit from Object.prototype [#6102](https://github.com/nodejs/node/pull/6102) | ||
| 172 | + | ||
| 173 | + @rvagg: Need choices to vote on. | ||
| 174 | + | ||
| 175 | + @ofrobots: Wants to explore more options including `map` so wait for vote. If the goal is to go to a map why don’t we do that now? | ||
| 176 | + | ||
| 177 | + @Fishrock123: Because community has taken dependencies on it being an object. | ||
| 178 | + | ||
| 179 | + @ofrobots: headers end up with “megamorphic IC’s” so wants to research further. | ||
| 180 | + | ||
| 181 | + @Fishrock123: We are fixing this because header names like `__proto__` conflict with default object properties. | ||
| 182 | + | ||
| 183 | + We should really just make an API for headers. | ||
| 184 | + | ||
| 185 | + @rvagg: We’ll come back to this next week. Prepare wording for vote if ready. | ||
| 186 | + | ||
| 187 | + **Next steps**: List available options and conduct vote next week. | ||
| 188 | + | ||
| 189 | + | ||
| 190 | + ## Q/A on public fora | ||
| 191 | + | ||
| 192 | + None. | ||
| 193 | + | ||
| 194 | + ## Upcoming Meetings | ||
| 195 | + | ||
| 196 | + * CTC: 2016-07-27 | ||
| 197 | + * TSC: 2016-07-28 | ||
| 198 | + * Build: 2016-08-07 | ||
| 199 | + * LTS: 2016-07-25 | ||
| 200 | + * Diagnostics: 2016-08-03 | ||
| 201 | + * Post-Mortem: August | ||
| 202 | + * API: August | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments