Commit 01e3190
src: general C++ cleanup in node_url.cc
- Merge `domain` and `opaque` storage in URL parser:
This just simplifies the code a bit, having multiple fields
in an union with the same type is usually just overhead.
- Add move variant of `URLHost::ToString()`:
This helps avoid unnecessary string copy operations, especially
since we control the lifetime of `URLHost` objects pretty well.
- Use const refs in node_url.cc where appropriate
- Remove or reduce overly generous `.reserve()` calls:
These would otherwise keep a lot of unused memory lying around.
- Return return values instead of unnecessary pointer arguments
- Use more common/expressive variable names
- Avoid macro use, reduce number of unnecessary JS strings:
There’s no reason for `GET`, `GET_AND_SET` and `UTF8STRING` to be
macros. Also, `GET` would previously create a JS string instance
for each single call, even though the strings it was called
with were compile-time constants.
- Avoid unnecessary JS casts when the type of a value is known
- Avoid (commonly unnecessary) copy for whitespace stripping
PR-URL: #19598
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>1 parent 9f20534 commit 01e3190
2 files changed
Lines changed: 192 additions & 151 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -170,11 +170,13 @@ struct PackageConfig { | |||
| 170 | 170 | V(fingerprint_string, "fingerprint") \ | |
| 171 | 171 | V(fingerprint256_string, "fingerprint256") \ | |
| 172 | 172 | V(flags_string, "flags") \ | |
| 173 | + V(fragment_string, "fragment") \ | ||
| 173 | 174 | V(get_data_clone_error_string, "_getDataCloneError") \ | |
| 174 | 175 | V(get_shared_array_buffer_id_string, "_getSharedArrayBufferId") \ | |
| 175 | 176 | V(gid_string, "gid") \ | |
| 176 | 177 | V(handle_string, "handle") \ | |
| 177 | 178 | V(homedir_string, "homedir") \ | |
| 179 | + V(host_string, "host") \ | ||
| 178 | 180 | V(hostmaster_string, "hostmaster") \ | |
| 179 | 181 | V(ignore_string, "ignore") \ | |
| 180 | 182 | V(infoaccess_string, "infoAccess") \ | |
@@ -232,6 +234,7 @@ struct PackageConfig { | |||
| 232 | 234 | V(order_string, "order") \ | |
| 233 | 235 | V(owner_string, "owner") \ | |
| 234 | 236 | V(parse_error_string, "Parse Error") \ | |
| 237 | + V(password_string, "password") \ | ||
| 235 | 238 | V(path_string, "path") \ | |
| 236 | 239 | V(pending_handle_string, "pendingHandle") \ | |
| 237 | 240 | V(pbkdf2_error_string, "PBKDF2 Error") \ | |
@@ -242,6 +245,7 @@ struct PackageConfig { | |||
| 242 | 245 | V(priority_string, "priority") \ | |
| 243 | 246 | V(produce_cached_data_string, "produceCachedData") \ | |
| 244 | 247 | V(pubkey_string, "pubkey") \ | |
| 248 | + V(query_string, "query") \ | ||
| 245 | 249 | V(raw_string, "raw") \ | |
| 246 | 250 | V(read_host_object_string, "_readHostObject") \ | |
| 247 | 251 | V(readable_string, "readable") \ | |
@@ -251,6 +255,7 @@ struct PackageConfig { | |||
| 251 | 255 | V(rename_string, "rename") \ | |
| 252 | 256 | V(replacement_string, "replacement") \ | |
| 253 | 257 | V(retry_string, "retry") \ | |
| 258 | + V(scheme_string, "scheme") \ | ||
| 254 | 259 | V(serial_string, "serial") \ | |
| 255 | 260 | V(scopeid_string, "scopeid") \ | |
| 256 | 261 | V(sent_shutdown_string, "sentShutdown") \ | |
0 commit comments