Commit 02e012e
src: force line buffering for stderr
SmartOS does not line buffer stderr by default, or at least that is the
behavior on the Node project Jenkins server. Force line buffering. This
resolves the flakiness observed on SmartOS for
test-debug-signal-cluster.
PR-URL: #3701
Fixes: #2476
Refs: #3615
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 597f875 commit 02e012e
2 files changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -41,6 +41,7 @@ int wmain(int argc, wchar_t *wargv[]) { | |||
| 41 | 41 | #else | |
| 42 | 42 | // UNIX | |
| 43 | 43 | int main(int argc, char *argv[]) { | |
| 44 | + setvbuf(stderr, NULL, _IOLBF, 1024); | ||
| 44 | 45 | return node::Start(argc, argv); | |
| 45 | 46 | } | |
| 46 | 47 | #endif | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,7 +18,6 @@ test-child-process-exit-code : PASS,FLAKY | |||
| 18 | 18 | [$system==macos] | |
| 19 | 19 | ||
| 20 | 20 | [$system==solaris] # Also applies to SmartOS | |
| 21 | - test-debug-signal-cluster : PASS,FLAKY | ||
| 22 | 21 | ||
| 23 | 22 | [$system==freebsd] | |
| 24 | 23 | test-net-socket-local-address : PASS,FLAKY | |
0 commit comments