Commit 02fbff4
test_runner: cache shouldSkipFileCoverage result per URL
`shouldSkipFileCoverage(url)` is invoked twice for every covered
script (once during source-map mapping and once during merge), and
the same script URL is typically reported by every worker. The
result depends only on `options.cwd`, `coverageExcludeGlobs`, and
`coverageIncludeGlobs`, all of which are fixed for the lifetime of
a TestCoverage instance, so the URL -> boolean mapping is
deterministic and safe to cache.
Add a private `#skipCache` SafeMap and split the method into a thin
caching wrapper plus a private `#computeShouldSkipFileCoverage`
that holds the original logic. Callers are unchanged.
This eliminates redundant glob and URL parsing work proportional to
the number of workers x scripts in the coverage report.
Refs: #55103
Signed-off-by: sangwook <rewq5991@gmail.com>
PR-URL: #63675
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>1 parent 9098585 commit 02fbff4
1 file changed
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -86,6 +86,7 @@ class TestCoverage { | |||
| 86 | 86 | ||
| 87 | 87 | #sourceLines = new SafeMap(); | |
| 88 | 88 | #typeScriptLines = new SafeSet(); | |
| 89 | + #skipCache = new SafeMap(); | ||
| 89 | 90 | ||
| 90 | 91 | getLines(fileUrl, source) { | |
| 91 | 92 | // Split the file source into lines. Make sure the lines maintain their | |
@@ -535,6 +536,14 @@ class TestCoverage { | |||
| 535 | 536 | } | |
| 536 | 537 | ||
| 537 | 538 | shouldSkipFileCoverage(url) { | |
| 539 | + const cached = this.#skipCache.get(url); | ||
| 540 | + if (cached !== undefined) return cached; | ||
| 541 | + const result = this.#computeShouldSkipFileCoverage(url); | ||
| 542 | + this.#skipCache.set(url, result); | ||
| 543 | + return result; | ||
| 544 | + } | ||
| 545 | + | ||
| 546 | + #computeShouldSkipFileCoverage(url) { | ||
| 538 | 547 | // This check filters out core modules, which start with 'node:' in | |
| 539 | 548 | // coverage reports, as well as any invalid coverages which have been | |
| 540 | 549 | // observed on Windows. | |
0 commit comments