Commit 0369278
build: add simdutf dir to include path in GN build
The GN build defaults `node_simdutf_path` to `//third_party/simdutf`,
the copy that ships in a Chromium checkout. That target doesn't put
its own directory on the include path, so the unqualified
`#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't
resolve unless the embedder adds the directory themselves.
Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config`
(used by libnode and node_cctest) and to node_js2c's `include_dirs`.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65382
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 1a4f5e5 commit 0369278
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -81,6 +81,7 @@ template("node_gn_build") { | |||
| 81 | 81 | "src/inspector:*", | |
| 82 | 82 | ] | |
| 83 | 83 | configs = [ ":node_external_config" ] | |
| 84 | + include_dirs = [ get_label_info(node_simdutf_path, "dir") ] | ||
| 84 | 85 | libs = [] | |
| 85 | 86 | cflags = [ "-Wno-microsoft-include" ] | |
| 86 | 87 | cflags_cc = [ | |
@@ -337,7 +338,10 @@ template("node_gn_build") { | |||
| 337 | 338 | "src/builtin_info.cc", | |
| 338 | 339 | "src/builtin_info.h", | |
| 339 | 340 | ] | |
| 340 | - include_dirs = [ "src" ] | ||
| 341 | + include_dirs = [ | ||
| 342 | + "src", | ||
| 343 | + get_label_info(node_simdutf_path, "dir"), | ||
| 344 | + ] | ||
| 341 | 345 | } | |
| 342 | 346 | ||
| 343 | 347 | action("run_node_js2c") { | |
0 commit comments