test: use --port=0 in debugger tests that do not have to work on 9229 · nodejs/node@041885e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 041885e

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

RafaelGSS

committed

test: use --port=0 in debugger tests that do not have to work on 9229

To avoid failures when there is another running process occupying the port 9229 which may happen if there is a stale process, use the --port argument of node-inspect to use a random port in tests that don't have to work on port 9229. The following tests are not touched: - test-debugger-custom-port: tests a specific port - test-debugger-debug-brk: tests a specific port - test-debugger-invalid-args: tests other inspect combinations - test-debugger-pid: node-inspect does not support -p and --port together - test-debugger-launch: tests that default port is 9229 PR-URL: #47274 Refs: #47146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 0bbce03 commit 041885e
Copy full SHA for 041885e

26 files changed

+26-25Lines changed: 26 additions & 25 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/sequential
  • test-debugger-auto-resume.mjs
  • test-debugger-backtrace.js
  • test-debugger-break.js
  • test-debugger-breakpoint-exists.js
  • test-debugger-clear-breakpoints.js
  • test-debugger-exceptions.js
  • test-debugger-exec-scope.mjs
  • test-debugger-exec.js
  • test-debugger-heap-profiler.js
  • test-debugger-help.mjs
  • test-debugger-launch.mjs
  • test-debugger-list.js
  • test-debugger-low-level.js
  • test-debugger-object-type-remote-object.js
  • test-debugger-preserve-breaks.js
  • test-debugger-profile-command.js
  • test-debugger-profile.js
  • test-debugger-repeat-last.js
  • test-debugger-restart-message.js
  • test-debugger-run-after-quit-restart.js
  • test-debugger-sb-before-load.js
  • test-debugger-scripts.js
  • test-debugger-set-context-line-number.mjs
  • test-debugger-use-strict.js
  • test-debugger-watch-validation.js
  • test-debugger-watchers.mjs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/sequential/test-debugger-auto-resume.mjs‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-auto-resume.mjs

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -21,7 +21,7 @@ addLibraryPath(process.env);
21	21	};
22	22	env.NODE_INSPECT_RESUME_ON_START = '1';
23	23
24		- const cli = startCLI([script], [], {
	24	+ const cli = startCLI(['--port=0', script], [], {
25	25	env,
26	26	});
27	27

Collapse file

‎test/sequential/test-debugger-backtrace.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-backtrace.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -13,7 +13,7 @@ const path = require('path');
13	13	{
14	14	const scriptFullPath = fixtures.path('debugger', 'backtrace.js');
15	15	const script = path.relative(process.cwd(), scriptFullPath);
16		- const cli = startCLI([script]);
	16	+ const cli = startCLI(['--port=0', script]);
17	17
18	18	async function runTest() {
19	19	try {

Collapse file

‎test/sequential/test-debugger-break.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-break.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -11,7 +11,7 @@ const path = require('path');
11	11
12	12	const scriptFullPath = fixtures.path('debugger', 'break.js');
13	13	const script = path.relative(process.cwd(), scriptFullPath);
14		- const cli = startCLI([script]);
	14	+ const cli = startCLI(['--port=0', script]);
15	15
16	16	(async () => {
17	17	await cli.waitForInitialBreak();

Collapse file

‎test/sequential/test-debugger-breakpoint-exists.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-breakpoint-exists.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -9,7 +9,7 @@ const startCLI = require('../common/debugger');
9	9
10	10	// Test for "Breakpoint at specified location already exists" error.
11	11	const script = fixtures.path('debugger', 'three-lines.js');
12		- const cli = startCLI([script]);
	12	+ const cli = startCLI(['--port=0', script]);
13	13
14	14	(async () => {
15	15	try {

Collapse file

‎test/sequential/test-debugger-clear-breakpoints.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-clear-breakpoints.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -13,7 +13,7 @@ const path = require('path');
13	13	{
14	14	const scriptFullPath = fixtures.path('debugger', 'break.js');
15	15	const script = path.relative(process.cwd(), scriptFullPath);
16		- const cli = startCLI([script]);
	16	+ const cli = startCLI(['--port=0', script]);
17	17
18	18	function onFatal(error) {
19	19	cli.quit();

Collapse file

‎test/sequential/test-debugger-exceptions.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-exceptions.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -13,7 +13,7 @@ const path = require('path');
13	13	{
14	14	const scriptFullPath = fixtures.path('debugger', 'exceptions.js');
15	15	const script = path.relative(process.cwd(), scriptFullPath);
16		- const cli = startCLI([script]);
	16	+ const cli = startCLI(['--port=0', script]);
17	17
18	18	(async () => {
19	19	try {

Collapse file

‎test/sequential/test-debugger-exec-scope.mjs‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-exec-scope.mjs

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -7,7 +7,7 @@ import startCLI from '../common/debugger.js';
7	7
8	8	import assert from 'assert';
9	9
10		- const cli = startCLI([path('debugger/backtrace.js')]);
	10	+ const cli = startCLI(['--port=0', path('debugger/backtrace.js')]);
11	11
12	12	try {
13	13	await cli.waitForInitialBreak();

Collapse file

‎test/sequential/test-debugger-exec.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-exec.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -8,7 +8,7 @@ const startCLI = require('../common/debugger');
8	8
9	9	const assert = require('assert');
10	10
11		- const cli = startCLI([fixtures.path('debugger/alive.js')]);
	11	+ const cli = startCLI(['--port=0', fixtures.path('debugger/alive.js')]);
12	12
13	13	async function waitInitialBreak() {
14	14	try {

Collapse file

‎test/sequential/test-debugger-heap-profiler.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-heap-profiler.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -17,7 +17,7 @@ const filename = path.join(tmpdir.path, 'node.heapsnapshot');
17	17	// Heap profiler take snapshot.
18	18	{
19	19	const opts = { cwd: tmpdir.path };
20		- const cli = startCLI([fixtures.path('debugger/empty.js')], [], opts);
	20	+ const cli = startCLI(['--port=0', fixtures.path('debugger/empty.js')], [], opts);
21	21
22	22	async function waitInitialBreak() {
23	23	try {

Collapse file

‎test/sequential/test-debugger-help.mjs‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-help.mjs

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -7,7 +7,7 @@ import startCLI from '../common/debugger.js';
7	7
8	8	import assert from 'assert';
9	9
10		- const cli = startCLI([path('debugger', 'empty.js')]);
	10	+ const cli = startCLI(['--port=0', path('debugger', 'empty.js')]);
11	11
12	12	try {
13	13	await cli.waitForInitialBreak();

0 commit comments

Comments

0 (0)