FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fill DOMException names · nodejs/node@043756d · GitHub

/ node Public

Commit 043756d

Browse files
LiviaMedeiros
authored and
targos
committed
test: fill DOMException names
PR-URL: #43615 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent e718a6e commit 043756d

5 files changed

Lines changed: 33 additions & 14 deletions

‎test/parallel/test-abortcontroller.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,10 @@ const { setTimeout: sleep } = require('timers/promises');
245245

246246
{
247247
// Test abortSignal.throwIfAborted()
248-
throws(() => AbortSignal.abort().throwIfAborted(), { code: 20 });
248+
throws(() => AbortSignal.abort().throwIfAborted(), {
249+
code: 20,
250+
name: 'AbortError',
251+
});
249252

250253
// Does not throw because it's not aborted.
251254
const ac = new AbortController();

‎test/parallel/test-filehandle-readablestream.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@ const check = readFileSync(__filename, { encoding: 'utf8' });
8080
const mc = new MessageChannel();
8181
mc.port1.onmessage = common.mustNotCall();
8282
assert.throws(() => mc.port2.postMessage(file, [file]), {
83-
code: 25 // DataCloneError
83+
code: 25,
84+
name: 'DataCloneError',
8485
});
8586
mc.port1.close();
8687
await file.close();

‎test/parallel/test-fs-promises-file-handle-read-worker.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ if (isMainThread || !workerData) {
2929
});
3030
}, {
3131
code: 25,
32+
name: 'DataCloneError',
3233
});
3334
} finally {
3435
await handle.close();

‎test/parallel/test-webcrypto-random.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,9 @@ for (const ctor of intTypedConstructors) {
6363
}
6464

6565
if (kData !== undefined) {
66-
assert.throws(() => webcrypto.getRandomValues(kData), {
67-
code: 22
68-
});
66+
assert.throws(
67+
() => webcrypto.getRandomValues(kData),
68+
{ name: 'QuotaExceededError', code: 22 },
69+
);
6970
}
7071
}

‎test/parallel/test-whatwg-webstreams-transfer.js‎

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -253,14 +253,16 @@ const theData = 'hello';
253253
start(c) { controller = c; },
254254

255255
cancel: common.mustCall((error) => {
256-
assert.strictEqual(error.code, 25); // DataCloneError
256+
assert.strictEqual(error.code, 25);
257+
assert.strictEqual(error.name, 'DataCloneError');
257258
}),
258259
});
259260

260261
port1.onmessage = ({ data }) => {
261262
const reader = data.getReader();
262263
assert.rejects(reader.read(), {
263-
code: 25, // DataCloneError
264+
code: 25,
265+
name: 'DataCloneError',
264266
});
265267
port1.close();
266268
};
@@ -354,7 +356,10 @@ const theData = 'hello';
354356

355357
const source = {
356358
abort: common.mustCall((error) => {
357-
process.nextTick(() => assert.strictEqual(error.code, 25));
359+
process.nextTick(() => {
360+
assert.strictEqual(error.code, 25);
361+
assert.strictEqual(error.name, 'DataCloneError');
362+
});
358363
})
359364
};
360365

@@ -366,7 +371,8 @@ const theData = 'hello';
366371
const m = new WebAssembly.Memory({ initial: 1 });
367372

368373
assert.rejects(writer.abort(m), {
369-
code: 25
374+
code: 25,
375+
name: 'DataCloneError',
370376
});
371377
port1.close();
372378
});
@@ -437,7 +443,10 @@ const theData = 'hello';
437443
{
438444
const source = {
439445
cancel: common.mustCall((error) => {
440-
process.nextTick(() => assert(error.code, 25));
446+
process.nextTick(() => {
447+
assert.strictEqual(error.code, 25);
448+
assert.strictEqual(error.name, 'DataCloneError');
449+
});
441450
}),
442451
};
443452

@@ -455,7 +464,8 @@ const theData = 'hello';
455464
reader.closed.then(common.mustCall());
456465

457466
assert.rejects(cancel, {
458-
code: 25
467+
code: 25,
468+
name: 'DataCloneError',
459469
});
460470

461471
port1.close();
@@ -469,6 +479,7 @@ const theData = 'hello';
469479
abort: common.mustCall((error) => {
470480
process.nextTick(() => {
471481
assert.strictEqual(error.code, 25);
482+
assert.strictEqual(error.name, 'DataCloneError');
472483
});
473484
}),
474485
};
@@ -481,7 +492,7 @@ const theData = 'hello';
481492
const m = new WebAssembly.Memory({ initial: 1 });
482493
const writer = data.getWriter();
483494
const write = writer.write(m);
484-
assert.rejects(write, { code: 25 });
495+
assert.rejects(write, { code: 25, name: 'DataCloneError' });
485496
port1.close();
486497
});
487498

@@ -492,12 +503,14 @@ const theData = 'hello';
492503
const readable = new ReadableStream();
493504
readable.getReader();
494505
assert.throws(() => readable[kTransfer](), {
495-
code: 25
506+
code: 25,
507+
name: 'DataCloneError',
496508
});
497509

498510
const writable = new WritableStream();
499511
writable.getWriter();
500512
assert.throws(() => writable[kTransfer](), {
501-
code: 25
513+
code: 25,
514+
name: 'DataCloneError',
502515
});
503516
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL