Commit 046343e
authored
build: warn for GCC versions earlier than 12.2
Update the warning threshold for GCC to 12.2 starting from Node.js 23.
Builds can still proceed with earlier versions of GCC, but are not
guaranteed to work.
PR-URL: #54081
Refs: nodejs/build#3806
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 3616ace commit 046343e
2 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -150,7 +150,7 @@ Depending on the host platform, the selection of toolchains may vary. | |||
| 150 | 150 | ||
| 151 | 151 | | Operating System | Compiler Versions | | |
| 152 | 152 | | ---------------- | -------------------------------------------------------------- | | |
| 153 | - | Linux | GCC >= 10.1 | | ||
| 153 | + | Linux | GCC >= 12.2 | | ||
| 154 | 154 | | Windows | Visual Studio >= 2022 with the Windows 10 SDK on a 64-bit host | | |
| 155 | 155 | | macOS | Xcode >= 13 (Apple LLVM >= 12) | | |
| 156 | 156 | ||
@@ -230,7 +230,7 @@ Consult previous versions of this document for older versions of Node.js: | |||
| 230 | 230 | ||
| 231 | 231 | #### Unix prerequisites | |
| 232 | 232 | ||
| 233 | - * `gcc` and `g++` >= 10.1 or newer | ||
| 233 | + * `gcc` and `g++` >= 12.2 or newer | ||
| 234 | 234 | * GNU Make 3.81 or newer | |
| 235 | 235 | * [A supported version of Python][Python versions] | |
| 236 | 236 | * For test coverage, your Python installation must include pip. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1178,8 +1178,8 @@ def check_compiler(o): | |||
| 1178 | 1178 | print_verbose(f"Detected {'clang ' if is_clang else ''}C++ compiler (CXX={CXX}) version: {version_str}") | |
| 1179 | 1179 | if not ok: | |
| 1180 | 1180 | warn(f'failed to autodetect C++ compiler version (CXX={CXX})') | |
| 1181 | - elif clang_version < (8, 0, 0) if is_clang else gcc_version < (10, 1, 0): | ||
| 1182 | - warn(f'C++ compiler (CXX={CXX}, {version_str}) too old, need g++ 10.1.0 or clang++ 8.0.0') | ||
| 1181 | + elif clang_version < (8, 0, 0) if is_clang else gcc_version < (12, 2, 0): | ||
| 1182 | + warn(f'C++ compiler (CXX={CXX}, {version_str}) too old, need g++ 12.2.0 or clang++ 8.0.0') | ||
| 1183 | 1183 | ||
| 1184 | 1184 | ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c') | |
| 1185 | 1185 | version_str = ".".join(map(str, clang_version if is_clang else gcc_version)) | |
0 commit comments