FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: swap var for let in url benchmarks · nodejs/node@048db38 · GitHub

/ node Public

Commit 048db38

Browse files
RamirezAlex
authored and
targos
committed
benchmark: swap var for let in url benchmarks
In benchmark url directory this changes for loops using var to let when it applies for consistency PR-URL: #28867 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 9b47f77 commit 048db38

14 files changed

Lines changed: 22 additions & 22 deletions

‎benchmark/url/legacy-vs-whatwg-url-get-prop.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function useLegacy(data) {
2626
// It's necessary to assign the values to an object
2727
// to avoid loop invariant code motion.
2828
bench.start();
29-
for (var i = 0; i < len; i++) {
29+
for (let i = 0; i < len; i++) {
3030
const obj = data[i];
3131
noDead.protocol = obj.protocol;
3232
noDead.auth = obj.auth;
@@ -55,7 +55,7 @@ function useWHATWG(data) {
5555
};
5656
const len = data.length;
5757
bench.start();
58-
for (var i = 0; i < len; i++) {
58+
for (let i = 0; i < len; i++) {
5959
const obj = data[i];
6060
noDead.protocol = obj.protocol;
6161
noDead.auth = `${obj.username}:${obj.password}`;

‎benchmark/url/legacy-vs-whatwg-url-parse.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function useLegacy(data) {
1515
const len = data.length;
1616
var result = url.parse(data[0]); // Avoid dead code elimination
1717
bench.start();
18-
for (var i = 0; i < len; ++i) {
18+
for (let i = 0; i < len; ++i) {
1919
result = url.parse(data[i]);
2020
}
2121
bench.end(len);
@@ -26,7 +26,7 @@ function useWHATWGWithBase(data) {
2626
const len = data.length;
2727
var result = new URL(data[0][0], data[0][1]); // Avoid dead code elimination
2828
bench.start();
29-
for (var i = 0; i < len; ++i) {
29+
for (let i = 0; i < len; ++i) {
3030
const item = data[i];
3131
result = new URL(item[0], item[1]);
3232
}
@@ -38,7 +38,7 @@ function useWHATWGWithoutBase(data) {
3838
const len = data.length;
3939
var result = new URL(data[0]); // Avoid dead code elimination
4040
bench.start();
41-
for (var i = 0; i < len; ++i) {
41+
for (let i = 0; i < len; ++i) {
4242
result = new URL(data[i]);
4343
}
4444
bench.end(len);

‎benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
1313
function useLegacy(n, input) {
1414
querystring.parse(input);
1515
bench.start();
16-
for (var i = 0; i < n; i += 1) {
16+
for (let i = 0; i < n; i += 1) {
1717
querystring.parse(input);
1818
}
1919
bench.end(n);
@@ -22,7 +22,7 @@ function useLegacy(n, input) {
2222
function useWHATWG(n, param) {
2323
new URLSearchParams(param);
2424
bench.start();
25-
for (var i = 0; i < n; i += 1) {
25+
for (let i = 0; i < n; i += 1) {
2626
new URLSearchParams(param);
2727
}
2828
bench.end(n);

‎benchmark/url/legacy-vs-whatwg-url-searchparams-serialize.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function useLegacy(n, input, prop) {
1414
const obj = querystring.parse(input);
1515
querystring.stringify(obj);
1616
bench.start();
17-
for (var i = 0; i < n; i += 1) {
17+
for (let i = 0; i < n; i += 1) {
1818
querystring.stringify(obj);
1919
}
2020
bench.end(n);
@@ -24,7 +24,7 @@ function useWHATWG(n, param, prop) {
2424
const obj = new URLSearchParams(param);
2525
obj.toString();
2626
bench.start();
27-
for (var i = 0; i < n; i += 1) {
27+
for (let i = 0; i < n; i += 1) {
2828
obj.toString();
2929
}
3030
bench.end(n);

‎benchmark/url/legacy-vs-whatwg-url-serialize.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function useLegacy(data) {
1515
const len = data.length;
1616
var noDead = url.format(obj);
1717
bench.start();
18-
for (var i = 0; i < len; i++) {
18+
for (let i = 0; i < len; i++) {
1919
noDead = data[i].toString();
2020
}
2121
bench.end(len);
@@ -27,7 +27,7 @@ function useWHATWG(data) {
2727
const len = data.length;
2828
var noDead = obj.toString();
2929
bench.start();
30-
for (var i = 0; i < len; i++) {
30+
for (let i = 0; i < len; i++) {
3131
noDead = data[i].toString();
3232
}
3333
bench.end(len);

‎benchmark/url/url-format.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ function main({ type, n }) {
2121
url.format(inputs[name]);
2222

2323
bench.start();
24-
for (var i = 0; i < n; i += 1)
24+
for (let i = 0; i < n; i += 1)
2525
url.format(input);
2626
bench.end(n);
2727
}

‎benchmark/url/url-parse.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ function main({ type, n }) {
1616
const input = inputs[type] || '';
1717

1818
bench.start();
19-
for (var i = 0; i < n; i += 1)
19+
for (let i = 0; i < n; i += 1)
2020
url.parse(input);
2121
bench.end(n);
2222
}

‎benchmark/url/url-resolve.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function main({ n, href, path }) {
2323
const p = paths[path];
2424

2525
bench.start();
26-
for (var i = 0; i < n; i += 1)
26+
for (let i = 0; i < n; i += 1)
2727
url.resolve(h, p);
2828
bench.end(n);
2929
}

‎benchmark/url/url-searchparams-iteration.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function forEach(n) {
1919
};
2020

2121
bench.start();
22-
for (var i = 0; i < n; i += 1)
22+
for (let i = 0; i < n; i += 1)
2323
params.forEach(cb);
2424
bench.end(n);
2525

@@ -32,7 +32,7 @@ function iterator(n) {
3232
const noDead = [];
3333

3434
bench.start();
35-
for (var i = 0; i < n; i += 1) {
35+
for (let i = 0; i < n; i += 1) {
3636
for (const pair of params) {
3737
noDead[0] = pair[0];
3838
noDead[1] = pair[1];

‎benchmark/url/url-searchparams-read.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ function main({ accessMethod, param, n }) {
1616
throw new Error(`Unknown method ${accessMethod}`);
1717

1818
bench.start();
19-
for (var i = 0; i < n; i += 1)
19+
for (let i = 0; i < n; i += 1)
2020
params[accessMethod](param);
2121
bench.end(n);
2222
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL