FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: V8: backport 1c3e018e7d48 · nodejs/node@0566799 · GitHub

/ node Public

Commit 0566799

Browse files
Renegade334
authored and
targos
committed
deps: V8: backport 1c3e018e7d48
Original commit message: Expose dispose and asyncDispose symbols to C++ Since `Symbol.dispose` has been exposed to JS we need to be able to access the native v8::Symbol too. Change-Id: I9111d2806630efdd8bb5f931effa9adad3c85ae5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6410112 Commit-Queue: Erik Corry <erikcorry@chromium.org> Reviewed-by: Erik Corry <erikcorry@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#99590} PR-URL: #58818 Refs: v8/v8@1c3e018 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent c37bef1 commit 0566799

4 files changed

Lines changed: 8 additions & 2 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.21',
41+
'v8_embedder_string': '-node.22',
4242

4343
##### V8 defaults for Node.js #####
4444

‎deps/v8/include/v8-primitive.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -819,6 +819,8 @@ class V8_EXPORT Symbol : public Name {
819819
static Local<Symbol> GetToPrimitive(Isolate* isolate);
820820
static Local<Symbol> GetToStringTag(Isolate* isolate);
821821
static Local<Symbol> GetUnscopables(Isolate* isolate);
822+
static Local<Symbol> GetDispose(Isolate* isolate);
823+
static Local<Symbol> GetAsyncDispose(Isolate* isolate);
822824

823825
V8_INLINE static Symbol* Cast(Data* data) {
824826
#ifdef V8_ENABLE_CHECKS

‎deps/v8/src/api/api.cc‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9548,7 +9548,9 @@ Local<Symbol> v8::Symbol::ForApi(Isolate* v8_isolate, Local<String> name) {
95489548
V(Split, split) \
95499549
V(ToPrimitive, to_primitive) \
95509550
V(ToStringTag, to_string_tag) \
9551-
V(Unscopables, unscopables)
9551+
V(Unscopables, unscopables) \
9552+
V(Dispose, dispose) \
9553+
V(AsyncDispose, async_dispose)
95529554

95539555
#define SYMBOL_GETTER(Name, name) \
95549556
Local<Symbol> v8::Symbol::Get##Name(Isolate* v8_isolate) { \

‎deps/v8/test/cctest/test-api.cc‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4006,6 +4006,8 @@ THREADED_TEST(WellKnownSymbols) {
40064006
CheckWellKnownSymbol(v8::Symbol::GetSplit, "Symbol.split");
40074007
CheckWellKnownSymbol(v8::Symbol::GetToPrimitive, "Symbol.toPrimitive");
40084008
CheckWellKnownSymbol(v8::Symbol::GetToStringTag, "Symbol.toStringTag");
4009+
CheckWellKnownSymbol(v8::Symbol::GetDispose, "Symbol.dispose");
4010+
CheckWellKnownSymbol(v8::Symbol::GetAsyncDispose, "Symbol.asyncDispose");
40094011
}
40104012

40114013

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL