Commit 05909d0
test: fix flaky test-vm-timeout-rethrow
The intention of test case is to make sure that `timeout` property is honored
and the code in context terminates and throws correct exception. However in
test case, the code inside context would complete before `timeout` for windows
and would sometimes fail. Updated the code so it guarantee to not complete
execution until timeout is triggered.
Fixes: #11261
PR-URL: #11530
Reviewed-By: James M Snell <jasnell.gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>1 parent a0c705e commit 05909d0
1 file changed
Lines changed: 2 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,15 +5,9 @@ var vm = require('vm'); | |||
| 5 | 5 | var spawn = require('child_process').spawn; | |
| 6 | 6 | ||
| 7 | 7 | if (process.argv[2] === 'child') { | |
| 8 | - var code = 'var j = 0;\n' + | ||
| 9 | - 'for (var i = 0; i < 1000000; i++) j += add(i, i + 1);\n' + | ||
| 10 | - 'j;'; | ||
| 8 | + const code = 'while(true);'; | ||
| 11 | 9 | ||
| 12 | - var ctx = vm.createContext({ | ||
| 13 | - add: function(x, y) { | ||
| 14 | - return x + y; | ||
| 15 | - } | ||
| 16 | - }); | ||
| 10 | + const ctx = vm.createContext(); | ||
| 17 | 11 | ||
| 18 | 12 | vm.runInContext(code, ctx, { timeout: 1 }); | |
| 19 | 13 | } else { | |
0 commit comments