Commit 05b7b8d
stream: fix error handling with async iteration
Fix an issue when an error was emitted by the stream before
`iterator.next()` is called.
PR-URL: #20329
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>1 parent 348d391 commit 05b7b8d
2 files changed
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -58,7 +58,7 @@ function onError(iter, err) { | |||
| 58 | 58 | iter[kLastReject] = null; | |
| 59 | 59 | reject(err); | |
| 60 | 60 | } | |
| 61 | - iter.error = err; | ||
| 61 | + iter[kError] = err; | ||
| 62 | 62 | } | |
| 63 | 63 | ||
| 64 | 64 | function wrapForNext(lastPromise, iter) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -115,6 +115,18 @@ async function tests() { | |||
| 115 | 115 | readable.destroy(new Error('kaboom')); | |
| 116 | 116 | })(); | |
| 117 | 117 | ||
| 118 | + await (async function() { | ||
| 119 | + console.log('call next() after error'); | ||
| 120 | + const readable = new Readable({ | ||
| 121 | + read() {} | ||
| 122 | + }); | ||
| 123 | + const iterator = readable[Symbol.asyncIterator](); | ||
| 124 | + | ||
| 125 | + const err = new Error('kaboom'); | ||
| 126 | + readable.destroy(new Error('kaboom')); | ||
| 127 | + await assert.rejects(iterator.next.bind(iterator), err); | ||
| 128 | + })(); | ||
| 129 | + | ||
| 118 | 130 | await (async function() { | |
| 119 | 131 | console.log('read object mode'); | |
| 120 | 132 | const max = 42; | |
0 commit comments