FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove common.disableCrashOnUnhandledRejection · nodejs/node@05df701 · GitHub

/ node Public

Commit 05df701

Browse files
targos
committed
test: remove common.disableCrashOnUnhandledRejection
Use the --unhandled-rejections=none CLI flag instead. PR-URL: #38210 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 3377eb9 commit 05df701

17 files changed

Lines changed: 7 additions & 47 deletions

‎doc/guides/writing-tests.md‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -250,11 +250,9 @@ countdown.dec(); // The countdown callback will be invoked now.
250250

251251
When writing tests involving promises, it is generally good to wrap the
252252
`onFulfilled` handler, otherwise the test could successfully finish if the
253-
promise never resolves (pending promises do not keep the event loop alive). The
254-
`common` module automatically adds a handler that makes the process crash - and
255-
hence, the test fail - in the case of an `unhandledRejection` event. It is
256-
possible to disable it with `common.disableCrashOnUnhandledRejection()` if
257-
needed.
253+
promise never resolves (pending promises do not keep the event loop alive).
254+
Node.js automatically crashes - and hence, the test fails - in the case of an
255+
`unhandledRejection` event.
258256

259257
```js
260258
const common = require('../common');

‎test/common/README.md‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,6 @@ On non-Windows platforms, this always returns `true`.
6161

6262
Creates a 10 MB file of all null characters.
6363

64-
### `disableCrashOnUnhandledRejection()`
65-
66-
Removes the `process.on('unhandledRejection')` handler that crashes the process
67-
after a tick. The handler is useful for tests that use Promises and need to make
68-
sure no unexpected rejections occur, because currently they result in silent
69-
failures. However, it is useful in some rare cases to disable it, for example if
70-
the `unhandledRejection` hook is directly used by the test.
71-
7264
### `enoughTestCpu`
7365

7466
* [&lt;boolean>][]

‎test/common/index.js‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -628,10 +628,6 @@ function getBufferSources(buf) {
628628
return [...getArrayBufferViews(buf), new Uint8Array(buf).buffer];
629629
}
630630

631-
function disableCrashOnUnhandledRejection() {
632-
process.on('unhandledRejection', () => {});
633-
}
634-
635631
function getTTYfd() {
636632
// Do our best to grab a tty fd.
637633
const tty = require('tty');
@@ -732,7 +728,6 @@ const common = {
732728
canCreateSymLink,
733729
childShouldThrowAndAbort,
734730
createZeroFilledFile,
735-
disableCrashOnUnhandledRejection,
736731
expectsError,
737732
expectWarning,
738733
gcUntil,

‎test/common/index.mjs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ const {
4646
skipIf32Bits,
4747
getArrayBufferViews,
4848
getBufferSources,
49-
disableCrashOnUnhandledRejection,
5049
getTTYfd,
5150
runWithInvalidFD
5251
} = common;
@@ -92,7 +91,6 @@ export {
9291
skipIf32Bits,
9392
getArrayBufferViews,
9493
getBufferSources,
95-
disableCrashOnUnhandledRejection,
9694
getTTYfd,
9795
runWithInvalidFD,
9896
createRequire

‎test/common/inspector-helper.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ function spawnChildProcess(inspectorFlags, scriptContents, scriptFile) {
2525
const handler = tearDown.bind(null, child);
2626
process.on('exit', handler);
2727
process.on('uncaughtException', handler);
28-
common.disableCrashOnUnhandledRejection();
2928
process.on('unhandledRejection', handler);
3029
process.on('SIGINT', handler);
3130

‎test/parallel/test-async-wrap-pop-id-during-load.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
'use strict';
22

3-
const common = require('../common');
3+
require('../common');
44

55
if (process.argv[2] === 'async') {
6-
common.disableCrashOnUnhandledRejection();
76
async function fn() {
87
fn();
98
throw new Error();
@@ -16,7 +15,7 @@ const { spawnSync } = require('child_process');
1615

1716
const ret = spawnSync(
1817
process.execPath,
19-
['--stack_size=150', __filename, 'async'],
18+
['--unhandled-rejections=none', '--stack_size=150', __filename, 'async'],
2019
{ maxBuffer: Infinity }
2120
);
2221
assert.strictEqual(ret.status, 0,

‎test/parallel/test-no-harmony-top-level-await.mjs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22

33
import {
44
mustCall,
5-
disableCrashOnUnhandledRejection
65
} from '../common/index.mjs';
76

8-
disableCrashOnUnhandledRejection();
9-
107
process.on('unhandledRejection', mustCall());
118
Promise.reject(new Error('should not be fatal error'));

‎test/parallel/test-promise-handled-rejection-no-warning.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
const common = require('../common');
33

44
// This test verifies that DEP0018 does not occur when rejections are handled.
5-
common.disableCrashOnUnhandledRejection();
65
process.on('warning', common.mustNotCall());
76
process.on('unhandledRejection', common.mustCall());
87
Promise.reject(new Error());

‎test/parallel/test-promise-unhandled-error.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ const common = require('../common');
55
const Countdown = require('../common/countdown');
66
const assert = require('assert');
77

8-
common.disableCrashOnUnhandledRejection();
9-
108
// Verify that unhandled rejections always trigger uncaught exceptions instead
119
// of triggering unhandled rejections.
1210

‎test/parallel/test-promise-unhandled-silent-no-hook.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
const common = require('../common');
55
const assert = require('assert');
66

7-
common.disableCrashOnUnhandledRejection();
8-
97
// Verify that ignoring unhandled rejection works fine and that no warning is
108
// logged even though there is no unhandledRejection hook attached.
119

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL