Commit 05e6ec0
build: make 'floating patch' message informational
Downgrade the 'Using floating patch' message that is emitted
when a local patch is applied to the bundled ICU from a warning
to a notice. There isn't anything the user can or should do so
warning isn't appropriate. Instead of angry yellow use soothing green.
Fixes: #26346
PR-URL: #26349
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>1 parent 8cf4170 commit 05e6ec0
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -617,6 +617,10 @@ def warn(msg): | |||
| 617 | 617 | # track if warnings occurred | |
| 618 | 618 | warn.warned = False | |
| 619 | 619 | ||
| 620 | + def info(msg): | ||
| 621 | + prefix = '\033[1m\033[32mINFO\033[0m' if os.isatty(1) else 'INFO' | ||
| 622 | + print('%s: %s' % (prefix, msg)) | ||
| 623 | + | ||
| 620 | 624 | def print_verbose(x): | |
| 621 | 625 | if not options.verbose: | |
| 622 | 626 | return | |
@@ -1288,7 +1292,7 @@ def glob_to_var(dir_base, dir_sub, patch_dir): | |||
| 1288 | 1292 | patchfile = '%s/%s/%s' % (dir_base, patch_dir, file) | |
| 1289 | 1293 | if os.path.isfile(patchfile): | |
| 1290 | 1294 | srcfile = '%s/%s' % (patch_dir, file) | |
| 1291 | - warn('Using floating patch "%s" from "%s"' % (patchfile, dir_base)) | ||
| 1295 | + info('Using floating patch "%s" from "%s"' % (patchfile, dir_base)) | ||
| 1292 | 1296 | list.append(srcfile) | |
| 1293 | 1297 | break | |
| 1294 | 1298 | return list | |
0 commit comments