benchmark: change iterations in benchmark/es/string-concatenations.js · nodejs/node@065d884 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 065d884

Browse filesBrowse the repository at this point in the historyBrowse files

Septa2112

authored and

targos

committed

benchmark: change iterations in benchmark/es/string-concatenations.js

Increase the number of iterations from `1e3` to `1e6` to avoid the test performance gap caused by inactive V8 optimization caused by too few iterations. Fixes: #50571 PR-URL: #50585 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

1 parent 22eb025 commit 065d884
Copy full SHA for 065d884

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• benchmark/es
  • string-concatenations.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎benchmark/es/string-concatenations.js‎

Copy file name to clipboardExpand all lines: benchmark/es/string-concatenations.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -3,7 +3,7 @@
3	3	const common = require('../common.js');
4	4
5	5	const configs = {
6		- n: [1e3],
	6	+ n: [1e6],
7	7	mode: [
8	8	'multi-concat',
9	9	'multi-join',

0 commit comments

Comments

0 (0)