vm: use import attributes instead of import assertions · nodejs/node@06646e1 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 06646e1

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

richardlau

committed

vm: use import attributes instead of import assertions

The old import assertions proposal has been renamed to "import attributes" with the following major changes: 1. The keyword is now `with` instead of `assert`. 2. Unknown assertions cause an error rather than being ignored. This PR updates the documentation to encourage folks to use the new syntax, and add aliases to preserve backward compatibility. PR-URL: #50141 Backport-PR-URL: #51136 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

1 parent a193be3 commit 06646e1
Copy full SHA for 06646e1

1 file changed

+6-6Lines changed: 6 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • vm.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/vm.md‎

Copy file name to clipboardExpand all lines: doc/api/vm.md

+6-6Lines changed: 6 additions & 6 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -103,7 +103,7 @@ changes:
103	103	[`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING_FLAG`][].
104	104	* `specifier` {string} specifier passed to `import()`
105	105	* `script` {vm.Script}
106		- * `importAttributes` {Object} The `"assert"` value passed to the
	106	+ * `importAttributes` {Object} The `"with"` value passed to the
107	107	[`optionsExpression`][] optional parameter, or an empty object if no value
108	108	was provided.
109	109	* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
@@ -635,7 +635,7 @@ changes:
635	635	* `extra` {Object}
636	636	* `attributes` {Object} The data from the attribute:
637	637	```mjs
638		- import foo from 'foo' assert { name: 'value' };
	638	+ import foo from 'foo' with { name: 'value' };
639	639	// ^^^^^^^^^^^^^^^^^ the attribute
640	640	```
641	641	Per ECMA-262, hosts are expected to trigger an error if an
@@ -1032,7 +1032,7 @@ changes:
1032	1032	[`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING_FLAG`][].
1033	1033	* `specifier` {string} specifier passed to `import()`
1034	1034	* `function` {Function}
1035		- * `importAttributes` {Object} The `"assert"` value passed to the
	1035	+ * `importAttributes` {Object} The `"with"` value passed to the
1036	1036	[`optionsExpression`][] optional parameter, or an empty object if no value
1037	1037	was provided.
1038	1038	* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
@@ -1258,7 +1258,7 @@ changes:
1258	1258	[`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING_FLAG`][].
1259	1259	* `specifier` {string} specifier passed to `import()`
1260	1260	* `script` {vm.Script}
1261		- * `importAttributes` {Object} The `"assert"` value passed to the
	1261	+ * `importAttributes` {Object} The `"with"` value passed to the
1262	1262	[`optionsExpression`][] optional parameter, or an empty object if no value
1263	1263	was provided.
1264	1264	* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
@@ -1359,7 +1359,7 @@ changes:
1359	1359	[`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING_FLAG`][].
1360	1360	* `specifier` {string} specifier passed to `import()`
1361	1361	* `script` {vm.Script}
1362		- * `importAttributes` {Object} The `"assert"` value passed to the
	1362	+ * `importAttributes` {Object} The `"with"` value passed to the
1363	1363	[`optionsExpression`][] optional parameter, or an empty object if no value
1364	1364	was provided.
1365	1365	* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
@@ -1441,7 +1441,7 @@ changes:
1441	1441	[`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING_FLAG`][].
1442	1442	* `specifier` {string} specifier passed to `import()`
1443	1443	* `script` {vm.Script}
1444		- * `importAttributes` {Object} The `"assert"` value passed to the
	1444	+ * `importAttributes` {Object} The `"with"` value passed to the
1445	1445	[`optionsExpression`][] optional parameter, or an empty object if no value
1446	1446	was provided.
1447	1447	* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is

0 commit comments

Comments

0 (0)