Commit 066ca98
src: use MaybeLocal.ToLocal instead of IsEmpty
This commit suggest using MaybeLocal.ToLocal and passing in the
Local<Function> fn.
The motivation for doing this is that the following
MaybeLocal.ToLocalChecked call can then be avoided.
PR-URL: #33312
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent b41affb commit 066ca98
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -171,11 +171,11 @@ MaybeLocal<Value> ExecuteBootstrapper(Environment* env, | |||
| 171 | 171 | MaybeLocal<Function> maybe_fn = | |
| 172 | 172 | NativeModuleEnv::LookupAndCompile(env->context(), id, parameters, env); | |
| 173 | 173 | ||
| 174 | - if (maybe_fn.IsEmpty()) { | ||
| 174 | + Local<Function> fn; | ||
| 175 | + if (!maybe_fn.ToLocal(&fn)) { | ||
| 175 | 176 | return MaybeLocal<Value>(); | |
| 176 | 177 | } | |
| 177 | 178 | ||
| 178 | - Local<Function> fn = maybe_fn.ToLocalChecked(); | ||
| 179 | 179 | MaybeLocal<Value> result = fn->Call(env->context(), | |
| 180 | 180 | Undefined(env->isolate()), | |
| 181 | 181 | arguments->size(), | |
0 commit comments