Commit 06a1c9b
assert: remove code that is never reached
The internal function `truncate()` is only called with the first
argument being the output of `util.inspect()`. `util.inspect()` calls
its own internal `formatValue()` which is guaranteed to return a string.
Therefore, we can remove the check in `truncate()` that the first
argument is a string as well as code to handle the case where it is not
a string.
PR-URL: #8132
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 9c826be commit 06a1c9b
1 file changed
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -61,11 +61,7 @@ assert.AssertionError = function AssertionError(options) { | |||
| 61 | 61 | util.inherits(assert.AssertionError, Error); | |
| 62 | 62 | ||
| 63 | 63 | function truncate(s, n) { | |
| 64 | - if (typeof s === 'string') { | ||
| 65 | - return s.length < n ? s : s.slice(0, n); | ||
| 66 | - } else { | ||
| 67 | - return s; | ||
| 68 | - } | ||
| 64 | + return s.slice(0, n); | ||
| 69 | 65 | } | |
| 70 | 66 | ||
| 71 | 67 | function getMessage(self) { | |
0 commit comments