Commit 06d592c
committed
src: simplify native immediate by using v8::Global
Unlike `node::Persistent`, `v8::Global` has move semantics and
can be used directly in STL containers.
PR-URL: #26254
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent ea26ac0 commit 06d592c
2 files changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -625,8 +625,7 @@ void Environment::CreateImmediate(native_immediate_callback cb, | |||
| 625 | 625 | native_immediate_callbacks_.push_back({ | |
| 626 | 626 | cb, | |
| 627 | 627 | data, | |
| 628 | - std::unique_ptr<Persistent<v8::Object>>(obj.IsEmpty() ? | ||
| 629 | - nullptr : new Persistent<v8::Object>(isolate_, obj)), | ||
| 628 | + v8::Global<v8::Object>(isolate_, obj), | ||
| 630 | 629 | ref | |
| 631 | 630 | }); | |
| 632 | 631 | immediate_info()->count_inc(1); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1143,7 +1143,7 @@ class Environment { | |||
| 1143 | 1143 | struct NativeImmediateCallback { | |
| 1144 | 1144 | native_immediate_callback cb_; | |
| 1145 | 1145 | void* data_; | |
| 1146 | - std::unique_ptr<Persistent<v8::Object>> keep_alive_; | ||
| 1146 | + v8::Global<v8::Object> keep_alive_; | ||
| 1147 | 1147 | bool refed_; | |
| 1148 | 1148 | }; | |
| 1149 | 1149 | std::vector<NativeImmediateCallback> native_immediate_callbacks_; | |
0 commit comments