doc: remove git:// protocol, adjust nits in onboarding.md · nodejs/node@06fdbcd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 06fdbcd

Browse filesBrowse the repository at this point in the historyBrowse files

LiviaMedeiros

authored and

juanarbol

committed

doc: remove git:// protocol, adjust nits in onboarding.md

PR-URL: #43045 Refs: https://github.blog/2021-09-01-improving-git-protocol-security-github/ Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

1 parent 1d973f0 commit 06fdbcd
Copy full SHA for 06fdbcd

2 files changed

+6-6Lines changed: 6 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/contributing
  • backporting-to-release-lines.md
• onboarding.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/contributing/backporting-to-release-lines.md‎

Copy file name to clipboardExpand all lines: doc/contributing/backporting-to-release-lines.md

+1-1Lines changed: 1 addition & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -54,7 +54,7 @@ replace that with the staging branch for the targeted release line.
54	54	```bash
55	55	# Assuming your fork of Node.js is checked out in $NODE_DIR,
56	56	# the origin remote points to your fork, and the upstream remote points
57		- # to git://github.com/nodejs/node
	57	+ # to git@github.com:nodejs/node.git
58	58	cd $NODE_DIR
59	59	# If v10.x-staging is checked out `pull` should be used instead of `fetch`
60	60	git fetch upstream v10.x-staging:v10.x-staging -f

Collapse file

‎onboarding.md‎

Copy file name to clipboardExpand all lines: onboarding.md

+5-5Lines changed: 5 additions & 5 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -39,11 +39,11 @@ onboarding session.
39	39	* Always create a branch in your own GitHub fork for pull requests
40	40	* Branches in the `nodejs/node` repository are only for release lines
41	41	* Add the canonical nodejs repository as `upstream` remote:
42		- * `git remote add upstream git://github.com/nodejs/node.git`
	42	+ * `git remote add upstream git@github.com:nodejs/node.git`
43	43	* To update from `upstream`:
44	44	* `git checkout master`
45		- * `git remote update -p` OR `git fetch --all`
46		- * `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
	45	+ * `git fetch upstream HEAD`
	46	+ * `git reset --hard FETCH_HEAD`
47	47	* Make a new branch for each pull request you submit.
48	48	* Membership: Consider making your membership in the Node.js GitHub
49	49	organization public. This makes it easier to identify collaborators.
@@ -203,9 +203,9 @@ needs to be pointed out separately during the onboarding.
203	203	## Exercise: Make a pull request adding yourself to the README
204	204
205	205	* Example:
206		- <https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8>
	206	+ <https://github.com/nodejs/node/commit/6669b3857f0f43ee0296eb7ac45086cd907b9e94>
207	207	* For raw commit message:
208		- `git show --format=%B b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8`
	208	+ `git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94`
209	209	* Collaborators are in alphabetical order by GitHub username.
210	210	* Optionally, include your personal pronouns.
211	211	* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message

0 commit comments

Comments

0 (0)