Commit 071fef5
doc: remove unadvisable cluster example
Applications should usually keep track of workers themselves to prevent
cross-referencing workers from different "groups" that are assigned to
separate tasks.
Additionally, it is unreasonable to assume that the 'data' event emitted
by a socket object will be an integer. While the example works when the
argument is a string (or Buffer), it can result in various issues (e.g.,
when id === '__proto__' since cluster.workers has a non-null prototype).
Refs: 5f08c3c
PR-URL: #41668
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>1 parent b63fb0f commit 071fef5
1 file changed
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1087,14 +1087,6 @@ for (const worker of Object.values(cluster.workers)) { | |||
| 1087 | 1087 | } | |
| 1088 | 1088 | ``` | |
| 1089 | 1089 | ||
| 1090 | - Using the worker's unique id is the easiest way to locate the worker. | ||
| 1091 | - | ||
| 1092 | - ```js | ||
| 1093 | - socket.on('data', (id) => { | ||
| 1094 | - const worker = cluster.workers[id]; | ||
| 1095 | - }); | ||
| 1096 | - ``` | ||
| 1097 | - | ||
| 1098 | 1090 | [Advanced serialization for `child_process`]: child_process.md#advanced-serialization | |
| 1099 | 1091 | [Child Process module]: child_process.md#child_processforkmodulepath-args-options | |
| 1100 | 1092 | [`.fork()`]: #clusterforkenv | |
0 commit comments