Commit 074c3c1
build: make --without-report a no-op
This commit makes the configure --without-report flag a no-op.
This commit also updates a test that depends on the report CLI
flags being conditionally present.
PR-URL: #32242
Fixes: #26293
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 96ad768 commit 074c3c1
2 files changed
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -538,12 +538,12 @@ | |||
| 538 | 538 | dest='without_npm', | |
| 539 | 539 | help='do not install the bundled npm (package manager)') | |
| 540 | 540 | ||
| 541 | + # Dummy option for backwards compatibility | ||
| 541 | 542 | parser.add_option('--without-report', | |
| 542 | 543 | action='store_true', | |
| 543 | - dest='without_report', | ||
| 544 | - help='build without report') | ||
| 544 | + dest='unused_without_report', | ||
| 545 | + help=optparse.SUPPRESS_HELP) | ||
| 545 | 546 | ||
| 546 | - # Dummy option for backwards compatibility | ||
| 547 | 547 | parser.add_option('--with-snapshot', | |
| 548 | 548 | action='store_true', | |
| 549 | 549 | dest='unused_with_snapshot', | |
@@ -1004,7 +1004,6 @@ def configure_node(o): | |||
| 1004 | 1004 | o['variables']['OS'] = 'android' | |
| 1005 | 1005 | o['variables']['node_prefix'] = options.prefix | |
| 1006 | 1006 | o['variables']['node_install_npm'] = b(not options.without_npm) | |
| 1007 | - o['variables']['node_report'] = b(not options.without_report) | ||
| 1008 | 1007 | o['variables']['debug_node'] = b(options.debug_node) | |
| 1009 | 1008 | o['default_configuration'] = 'Debug' if options.debug else 'Release' | |
| 1010 | 1009 | ||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -59,8 +59,6 @@ const conditionalOpts = [ | |||
| 59 | 59 | filter: (opt) => opt === '--icu-data-dir' }, | |
| 60 | 60 | { include: process.features.inspector, | |
| 61 | 61 | filter: (opt) => opt.startsWith('--inspect') || opt === '--debug-port' }, | |
| 62 | - { include: process.config.variables.node_report, | ||
| 63 | - filter: (opt) => opt.includes('-report') }, | ||
| 64 | 62 | ]; | |
| 65 | 63 | documented.forEach((opt) => { | |
| 66 | 64 | conditionalOpts.forEach(({ include, filter }) => { | |
0 commit comments