Commit 0783ddf
buffer: do not leak memory if buffer is too big
A recent pull request changed this method to throw when the buffer was
too big, but this meant that the `free` finalizer would never get
called, leading to a memory leak.
A previous version of this diff included a test provoking this behavior
with `v8.serialize`, but it unfortunately kept triggering the OOM
killer, so it was removed.
Refs: #40243
PR-URL: #43938
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 8850555 commit 0783ddf
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -497,6 +497,7 @@ MaybeLocal<Object> New(Environment* env, | |||
| 497 | 497 | if (length > kMaxLength) { | |
| 498 | 498 | Isolate* isolate(env->isolate()); | |
| 499 | 499 | isolate->ThrowException(ERR_BUFFER_TOO_LARGE(isolate)); | |
| 500 | + free(data); | ||
| 500 | 501 | return Local<Object>(); | |
| 501 | 502 | } | |
| 502 | 503 | } | |
0 commit comments