doc: make some parameters optional in `tracingChannel.traceCallback` · nodejs/node@07bde05 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 07bde05

Browse filesBrowse the repository at this point in the historyBrowse files

deokjinkim

authored and

targos

committed

doc: make some parameters optional in tracingChannel.traceCallback

Plus, add missing `position` parameter to CJS example. PR-URL: #54068 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

1 parent 782a6a0 commit 07bde05
Copy full SHA for 07bde05

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • diagnostics_channel.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/diagnostics_channel.md‎

Copy file name to clipboardExpand all lines: doc/api/diagnostics_channel.md

+2-2Lines changed: 2 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -863,7 +863,7 @@ channels.tracePromise(async () => {
863	863	});
864	864	```
865	865
866		- #### `tracingChannel.traceCallback(fn, position, context, thisArg, ...args)`
	866	+ #### `tracingChannel.traceCallback(fn[, position[, context[, thisArg[, ...args]]]])`
867	867
868	868	<!-- YAML
869	869	added:
@@ -917,7 +917,7 @@ const channels = diagnostics_channel.tracingChannel('my-channel');
917	917	channels.traceCallback((arg1, callback) => {
918	918	// Do something
919	919	callback(null, 'result');
920		- }, {
	920	+ }, 1, {
921	921	some: 'thing',
922	922	}, thisArg, arg1, callback);
923	923	```

0 commit comments

Comments

0 (0)